NE-2422: Skip Gateway API tests on dual-stack clusters

[alebedev87]

Dual-stack support for Gateway API is not yet declared, skip the GatewayAPIController tests on AWS dual-stack clusters.

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci-robot]

@alebedev87: This pull request references NE-2422 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Dual-stack support for Gateway API is not yet declared, skip the GatewayAPIController tests on AWS dual-stack clusters.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7c454510-f46e-483a-8eee-4841db79b5c9

📥 Commits

Reviewing files that changed from the base of the PR and between e368054 and f51f6f0.

📒 Files selected for processing (1)

• test/extended/router/gatewayapicontroller.go

---

Walkthrough

A test helper function for Gateway API controller tests was renamed and extended. It now skips tests on both non-cloud platforms lacking load balancer support and dual-stack clusters where dual-stack support isn't declared. The function documentation was updated accordingly.

Changes

Cohort / File(s)	Summary
Gateway API Test Helper test/extended/router/gatewayapicontroller.go	Renamed skipGatewayIfNonCloudPlatform() to skipGatewayForUnsupportedPlatform() and extended skip logic to additionally check for dual-stack IP family configurations in AWS platform status. Updated function documentation and call site in BeforeEach.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.4)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[alebedev87]

/test e2e-vsphere-ovn

[sadasu]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87, sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• test/extended/router/OWNERS [alebedev87]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sadasu]

@alebedev87 thanks for cleaning up these tests so quickly.

[alebedev87]

/test e2e-vsphere-ovn-upi
/test e2e-metal-ipi-ovn-ipv6

[alebedev87]

/test e2e-aws-ovn-fips

[alebedev87]

/testwith openshift/installer/main/e2e-aws-ovn-dualstack-ipv6-primary-techpreview openshift/cloud-provider-aws#135 openshift/installer#10380

[alebedev87]

/testwith openshift/installer/main/e2e-aws-ovn-dualstack-ipv6-primary-techpreview

[alebedev87]

/verified by @alebedev87

[openshift-ci-robot]

@alebedev87: This PR has been marked as verified by @alebedev87.

Details

In response to this:

/verified by @alebedev87

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 31582ab and 2 for PR HEAD f51f6f0 in total

[alebedev87]

/test e2e-aws-ovn-serial-2of2

[openshift-ci]

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.