OCPBUGS-81629: Skip NoRegistryClusterInstall feature tests if InternalReleaseImage resource was not present

[andfasano]

This patch ensures that the NoRegistryClusterInstall feature tests will be executed only in the expected scenarios

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci-robot]

@andfasano: This pull request references Jira Issue OCPBUGS-81629, which is invalid:

• expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This patch ensures that the NoRegistryClusterInstall feature tests will be executed only in the expected scenarios

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9eb69aae-5663-4116-9bcf-8010f9a684a5

📥 Commits

Reviewing files that changed from the base of the PR and between 5381ae3 and 1907014.

📒 Files selected for processing (1)

• test/extended/internalreleaseimage/helper.go

🚧 Files skipped from review as they are similar to previous changes (1)

• test/extended/internalreleaseimage/helper.go

---

Walkthrough

After confirming the NoRegistryClusterInstall feature gate, skipIfNoRegistryFeatureUnsupported now attempts to Get the InternalReleaseImage resource via the MachineConfiguration v1alpha1 client and skips the test if the resource is NotFound or if any error occurs during the lookup.

Changes

Cohort / File(s)	Summary
Helper Function Enhancement test/extended/internalreleaseimage/helper.go	After feature-gate check, call MachineConfigurationV1alpha1 client's Get for the InternalReleaseImage named IRIResourceName; skip test on NotFound or any retrieval error.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[andfasano]

/jira refresh

[openshift-ci-robot]

@andfasano: This pull request references Jira Issue OCPBUGS-81629, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[bfournie]

/lgtm

[bfournie]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano, bfournie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• test/extended/internalreleaseimage/OWNERS [andfasano,bfournie]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[andfasano]

/test e2e-aws-ovn-microshift

[sadasu]

/verified later by CI

[openshift-ci-robot]

@sadasu: Only users can be targets for the /verified later command.

Details

In response to this:

/verified later by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[andfasano]

/verified by @andfasano

[openshift-ci-robot]

@andfasano: This PR has been marked as verified by @andfasano.

Details

In response to this:

/verified by @andfasano

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD c10db65 and 2 for PR HEAD 1907014 in total

[andfasano]

/retest required

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD 85dec4b and 1 for PR HEAD 1907014 in total

[andfasano]

/test e2e-aws-ovn-fips

[openshift-trt]

Job Failure Risk Analysis for sha: 1907014

Job Name	Failure Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-fips	IncompleteTests Tests for this run (30) are below the historical average (3147): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

[andfasano]

/test e2e-aws-ovn-fips

[openshift-ci]

@andfasano: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@andfasano: Jira Issue Verification Checks: Jira Issue OCPBUGS-81629
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-81629 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

This patch ensures that the NoRegistryClusterInstall feature tests will be executed only in the expected scenarios

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.