OCPEDGE-2510: fix(two-node): bump node replacement timeouts for new node installer pods by jaypoulz · Pull Request #31005 · openshift/origin

jaypoulz · 2026-04-13T18:28:28Z

Align wait windows with observed runtimes when installer pods run longer on bare-metal two-node fencing (TNF).

Made-with: Cursor
Agent: Auto

Summary by CodeRabbit

Tests
- Enhanced control-plane node replacement validation by adjusting static pod manifest initialization timing. Extended the timeout window and modified the polling frequency to improve test reliability when replacement nodes prepare their configurations.

…ode installer pods Align wait windows with observed runtimes when installer pods run longer on bare-metal two-node fencing (TNF). Made-with: Cursor Agent: Auto

openshift-merge-bot · 2026-04-13T18:28:31Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

openshift-ci-robot · 2026-04-13T18:28:32Z

@jaypoulz: This pull request references OCPEDGE-2510 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Align wait windows with observed runtimes when installer pods run longer on bare-metal two-node fencing (TNF).

Made-with: Cursor
Agent: Auto

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-04-13T18:28:56Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: b559f1ff-8dae-4adb-96de-c99f75c1ee79

📥 Commits

Reviewing files that changed from the base of the PR and between 1a93dad and 94c8367.

📒 Files selected for processing (1)

test/extended/two_node/tnf_node_replacement_const.go

Walkthrough

Adjusted static pod installer manifest waiting behavior in a test configuration by increasing the wait timeout from 2 to 5 minutes and decreasing the poll interval from 45 to 30 seconds for replacement control-plane node initialization.

Changes

Cohort / File(s)	Summary
Test Configuration Constants `test/extended/two_node/tnf_node_replacement_const.go`	Updated polling constants for static pod manifest installation: increased `staticPodManifestsWaitTimeout` from 2 to 5 minutes and reduced `staticPodManifestsPollInterval` from 45 to 30 seconds.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (2 inconclusive)

Check name	Status	Explanation	Resolution
Stable And Deterministic Test Names	❓ Inconclusive	File test/extended/two_node/tnf_node_replacement_const.go cannot be located in the repository. Unable to verify if test names follow stable and deterministic naming patterns.	Verify the file path exists and examine Ginkgo test definitions (It(), Describe(), Context()) to ensure test names do not contain dynamic values or format strings.
Test Structure And Quality	❓ Inconclusive	Unable to locate the file tnf_node_replacement_const.go in the repository structure after searching multiple locations.	Verify the correct file path and ensure the repository contains the file mentioned in the pull request summary.

✅ Passed checks (8 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly describes the main change: bumping node replacement timeouts for installer pods, which aligns with the adjustment of staticPodManifestsWaitTimeout and staticPodManifestsPollInterval constants.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Microshift Test Compatibility	✅ Passed	PR only modifies timeout and polling interval constants; no new Ginkgo e2e tests are added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR only modifies timeout and polling interval constants; no new Ginkgo e2e tests are added, so custom check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	PR modifies only test timeout and polling interval constants without introducing scheduling constraints or affecting topology compatibility.
Ote Binary Stdout Contract	✅ Passed	The modified file contains only static const declarations with no executable code, function definitions, or initialization logic that could produce stdout output.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR adjusts timeout and poll interval constants in an existing file without introducing new Ginkgo e2e tests, so IPv6 and disconnected network compatibility check is not applicable.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

jaypoulz · 2026-04-13T18:29:36Z

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-recovery-techpreview periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-dualstack-recovery-techpreview periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-ipv6-recovery-techpreview

openshift-ci · 2026-04-13T18:29:40Z

@jaypoulz: trigger 5 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-recovery-techpreview-1of3
periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-recovery-techpreview-2of3
periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-recovery-techpreview-3of3
periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-dualstack-recovery-techpreview
periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-ipv6-recovery-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ba133990-3766-11f1-9b5c-e92472ef8333-0

openshift-ci-robot · 2026-04-13T18:30:29Z

@jaypoulz: This pull request references OCPEDGE-2510 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Align wait windows with observed runtimes when installer pods run longer on bare-metal two-node fencing (TNF).

Made-with: Cursor
Agent: Auto

Summary by CodeRabbit

Tests

Enhanced control-plane node replacement validation by adjusting static pod manifest initialization timing. Extended the timeout window and modified the polling frequency to improve test reliability when replacement nodes prepare their configurations.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jaypoulz · 2026-04-13T19:46:38Z

/jira refresh

openshift-ci-robot · 2026-04-13T19:48:20Z

@jaypoulz: This pull request references OCPEDGE-2510 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jaypoulz · 2026-04-13T20:02:36Z

/retest-required

openshift-merge-bot · 2026-04-13T20:34:36Z

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-metal-ovn-two-node-arbiter
/test e2e-metal-ovn-two-node-fencing
/test e2e-metal-ovn-two-node-fencing-recovery

jaypoulz · 2026-04-15T13:49:32Z

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-recovery-techpreview periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-dualstack-recovery-techpreview periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-ipv6-recovery-techpreview

openshift-ci · 2026-04-15T13:49:37Z

@jaypoulz: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

jaypoulz · 2026-04-15T13:49:42Z

/retest-required

jaypoulz · 2026-04-15T16:19:10Z

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-recovery periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-dualstack-recovery periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-ipv6-recovery

openshift-ci · 2026-04-15T16:19:19Z

@jaypoulz: trigger 5 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-recovery-1of3
periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-recovery-2of3
periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-recovery-3of3
periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-dualstack-recovery
periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-ipv6-recovery

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d61e0080-38e6-11f1-8242-3e0e3c183047-0

jaypoulz · 2026-04-16T18:37:03Z

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-recovery periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-dualstack-recovery periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-ipv6-recovery

openshift-ci · 2026-04-16T18:37:06Z

@jaypoulz: trigger 5 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-recovery-1of3
periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-recovery-2of3
periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-recovery-3of3
periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-dualstack-recovery
periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-ipv6-recovery

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/437d7f20-39c3-11f1-95cb-af32c78faf12-0

jaypoulz · 2026-04-17T14:17:24Z

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-ipv6-recovery

openshift-ci · 2026-04-17T14:17:28Z

@jaypoulz: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-ipv6-recovery

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/28810570-3a68-11f1-9547-592e2b9290cb-0

jaypoulz · 2026-04-17T14:17:30Z

/retest-required

jaypoulz · 2026-04-17T14:18:28Z

reviewing the results from #31005 (comment), it appears neither ipv4 and dualstack ran into the bug. The ipv6 failed for unrelated reasons, but I suspect will pass this run if it picks up the latest payload since that will have Fonta's race condition fix.

jaypoulz · 2026-04-20T17:04:30Z

/verified by #31005 (comment) (IPv4, Dualstack) and #31005 (comment) (IPv6)

openshift-ci-robot · 2026-04-20T17:04:44Z

@jaypoulz: This PR has been marked as verified by https://github.com/openshift/origin/pull/31005#issuecomment-4262540278 (IPv4,Dualstack) and https://github.com/openshift/origin/pull/31005#issuecomment-4268834187 (IPv6).

Details

In response to this:

/verified by #31005 (comment) (IPv4, Dualstack) and #31005 (comment) (IPv6)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

eggfoobar · 2026-04-20T17:07:37Z

/lgtm

openshift-ci · 2026-04-20T17:08:04Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eggfoobar, jaypoulz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~test/extended/two_node/OWNERS~~ [eggfoobar,jaypoulz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jaypoulz · 2026-04-20T17:11:28Z

/retest-required

openshift-merge-bot · 2026-04-20T17:30:46Z

/retest-required

Remaining retests: 0 against base HEAD ff48d7a and 2 for PR HEAD 94c8367 in total

jaypoulz · 2026-04-20T18:04:16Z

/test e2e-aws-ovn-fips

openshift-ci · 2026-04-20T18:12:36Z

@jaypoulz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-ovn-two-node-fencing	`94c8367`	link	false	`/test e2e-metal-ovn-two-node-fencing`
ci/prow/e2e-vsphere-ovn	`94c8367`	link	true	`/test e2e-vsphere-ovn`
ci/prow/e2e-gcp-ovn	`94c8367`	link	true	`/test e2e-gcp-ovn`
ci/prow/e2e-metal-ovn-two-node-fencing-recovery	`94c8367`	link	false	`/test e2e-metal-ovn-two-node-fencing-recovery`
ci/prow/e2e-metal-ovn-two-node-arbiter	`94c8367`	link	false	`/test e2e-metal-ovn-two-node-arbiter`
ci/prow/e2e-metal-ipi-ovn-ipv6	`94c8367`	link	true	`/test e2e-metal-ipi-ovn-ipv6`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-trt · 2026-04-20T20:16:16Z

Job Failure Risk Analysis for sha: 94c8367

Job Name	Failure Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-fips	IncompleteTests Tests for this run (22) are below the historical average (3568): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-vsphere-ovn-upi	IncompleteTests Tests for this run (18) are below the historical average (3598): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

jaypoulz · 2026-04-21T12:16:38Z

/retest-required

OCPEDGE-2510: fix(two-node): bump node replacement timeouts for new n…

94c8367

…ode installer pods Align wait windows with observed runtimes when installer pods run longer on bare-metal two-node fencing (TNF). Made-with: Cursor Agent: Auto

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 13, 2026

openshift-ci Bot requested review from Neilhamza and lucaconsalvi April 13, 2026 18:28

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 20, 2026

openshift-ci Bot assigned eggfoobar Apr 20, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2026

openshift-merge-bot Bot merged commit a82f9be into openshift:main Apr 21, 2026
21 of 24 checks passed

Conversation

jaypoulz commented Apr 13, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

openshift-merge-bot Bot commented Apr 13, 2026

Uh oh!

openshift-ci-robot commented Apr 13, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Pre-merge checks failed

❌ Failed checks (2 inconclusive)

Uh oh!

jaypoulz commented Apr 13, 2026

Uh oh!

openshift-ci Bot commented Apr 13, 2026

Uh oh!

openshift-ci-robot commented Apr 13, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

jaypoulz commented Apr 13, 2026

Uh oh!

openshift-ci-robot commented Apr 13, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jaypoulz commented Apr 13, 2026

Uh oh!

openshift-merge-bot Bot commented Apr 13, 2026

Uh oh!

jaypoulz commented Apr 15, 2026

Uh oh!

openshift-ci Bot commented Apr 15, 2026

Uh oh!

jaypoulz commented Apr 15, 2026

Uh oh!

jaypoulz commented Apr 15, 2026

Uh oh!

openshift-ci Bot commented Apr 15, 2026

Uh oh!

jaypoulz commented Apr 16, 2026

Uh oh!

openshift-ci Bot commented Apr 16, 2026

Uh oh!

jaypoulz commented Apr 17, 2026

Uh oh!

openshift-ci Bot commented Apr 17, 2026

Uh oh!

jaypoulz commented Apr 17, 2026

Uh oh!

jaypoulz commented Apr 17, 2026

Uh oh!

jaypoulz commented Apr 20, 2026

Uh oh!

openshift-ci-robot commented Apr 20, 2026

Uh oh!

eggfoobar commented Apr 20, 2026

Uh oh!

openshift-ci Bot commented Apr 20, 2026

Uh oh!

jaypoulz commented Apr 20, 2026

Uh oh!

openshift-merge-bot Bot commented Apr 20, 2026

Uh oh!

jaypoulz commented Apr 20, 2026

Uh oh!

openshift-ci Bot commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-trt Bot commented Apr 20, 2026

Uh oh!

jaypoulz commented Apr 21, 2026

Uh oh!

Uh oh!

Reviewers

jaypoulz commented Apr 13, 2026 •

edited by coderabbitai Bot

Loading

openshift-ci-robot commented Apr 13, 2026 •

edited by openshift-ci Bot

Loading

coderabbitai Bot commented Apr 13, 2026 •

edited

Loading

openshift-ci-robot commented Apr 13, 2026 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Apr 13, 2026 •

edited by openshift-ci Bot

Loading

openshift-ci Bot commented Apr 20, 2026 •

edited

Loading