OCPBUGS-83286: Fix case-sensitive error matching in Whereabouts IP allocation test#31012
Conversation
Update the test to match the exact error string returned by the cmd add operation. Reference: https://github.com/openshift/whereabouts-cni/blob/release-4.22/cmd/whereabouts.go#L90 Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
WalkthroughA test condition in the network monitor tests was adjusted to match error messages with different capitalization. The substring filter for whereabouts IP allocation failures was changed from "Error" to "error" at the beginning of the error message to accommodate case variations in error output. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 8 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (8 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Scheduling required tests: |
| if strings.Contains(event.Locator.Keys[monitorapi.LocatorPodKey], "whereabouts-pod") && | ||
| strings.Contains(event.Message.HumanMessage, "error adding container to network") && | ||
| strings.Contains(event.Message.HumanMessage, "Error at storage engine: Could not allocate IP in range: ip: 192.168.2.225 / - 192.168.2.230 ") { | ||
| strings.Contains(event.Message.HumanMessage, "error at storage engine: Could not allocate IP in range: ip: 192.168.2.225 / - 192.168.2.230 ") { |
There was a problem hiding this comment.
this error only surfaces when in CI the time taken for the delete of the pod takes more than 5seconds.
hence we weren't running into this issue, however really that test in whereabouts should fail.
|
/approve |
|
@dgoodwin could you please approve this one? |
|
retitle OCPBUGS-83286: Fix case-sensitive error matching in Whereabouts IP allocation test |
|
/retitle OCPBUGS-83286: Fix case-sensitive error matching in Whereabouts IP allocation test |
|
@pperiyasamy: This pull request references Jira Issue OCPBUGS-83286, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@tssurya: This pull request references Jira Issue OCPBUGS-83286, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgoodwin, pperiyasamy, tssurya The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/verified by ci The job https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/31012/pull-ci-openshift-origin-main-e2e-gcp-ovn/2044354401346260992 is not having whereabouts flake anymore. whereas it's seen with other jobs, for example https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/30922/pull-ci-openshift-origin-main-e2e-gcp-ovn/2044364306614587392: |
|
@pperiyasamy: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherry-pick release-4.22 |
|
@tssurya: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-vsphere-ovn-upi |
1 similar comment
|
/test e2e-vsphere-ovn-upi |
|
/test e2e-vsphere-ovn-upi |
|
Job Failure Risk Analysis for sha: 5657022
|
|
/hold Revision 5657022 was retested 3 times: holding |
|
/hold cancel |
|
/test e2e-vsphere-ovn-upi |
|
/override ci/prow/e2e-vsphere-ovn-upi |
|
@neisw: Overrode contexts on behalf of neisw: ci/prow/e2e-vsphere-ovn-upi DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@pperiyasamy: Jira Issue Verification Checks: Jira Issue OCPBUGS-83286 Jira Issue OCPBUGS-83286 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@pperiyasamy: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@tssurya: new pull request created: #31029 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Update the test to match the exact error string returned by the cmd add operation.
Reference:
https://github.com/openshift/whereabouts-cni/blob/release-4.22/cmd/whereabouts.go#L90
'
'
Summary by CodeRabbit