[release-4.22] OCPBUGS-84319: cache kube client instance#31067
Conversation
oc client is a generic acessor for all the OpenShift API clients, as well as the typed kubernetes.Interface client. However the acessor for those clients require reading the configuration file from disk and parsing it again. This not only uses more processing, but also more IO, increasing the chance for an IO failure. This update is caching the clients used during the tests, so converting lots of IO and config parsing into a single one per test.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-84244 has been cloned as Jira Issue OCPBUGS-84319. Will retitle bug to link to clone. WARNING: Unexpected sprint field type []interface {} on source issue. Please update sprint manually on clone. /retitle [release-4.22] OCPBUGS-84319: cache kube client instance DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-84319, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@jcmoraisjr: This pull request references Jira Issue OCPBUGS-84319, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
The pre-submit jobs for 4.22 don't start automatically, not sure if this is still a bug, but I was told to manually trigger them. |
|
/test ? |
|
Here are the required jobs: |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gcs278, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
unrelated failures to DCM |
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
as this a flaky e2e case which can only verified after long observation of the CI and now is passing, i am marking as verified |
|
@melvinjoseph86: This PR has been marked to be verified later by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label backport-risk-assessed Looks ok though I'm suspicious there's a bigger and long standing issue in the test framework: https://redhat.atlassian.net/browse/OCPBUGS-84504 |
8682bf8
into
openshift:release-4.22
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-84319: All pull requests linked via external trackers have merged: This pull request has the DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
This is an automated cherry-pick of #30997
/assign jcmoraisjr