Skip to content

SREP-4676: add exception for managed cluster namespaces#31082

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
bmeng:default-sa
Apr 29, 2026
Merged

SREP-4676: add exception for managed cluster namespaces#31082
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
bmeng:default-sa

Conversation

@bmeng
Copy link
Copy Markdown
Contributor

@bmeng bmeng commented Apr 28, 2026

Adding exception for the namespaces are only for managed clusters.

Each of the exception being tracked by JIRA card. Can remove them once the issue fixed in operators.

Fixes: SREP-4676

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 28, 2026

Walkthrough

A monitor test configuration is extended with two additional exception matchers to recognize pods from the openshift-route-monitor-operator and openshift-security namespaces when they use the default service account.

Changes

Cohort / File(s) Summary
Monitor Test Exceptions
pkg/monitortests/authentication/nodefaultserviceaccountoperatortests/monitortest.go
Added two exception matchers to allow pods from openshift-route-monitor-operator/blackbox-exporter-* and openshift-security/* namespaces to use the default service account without being flagged as failures.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (2 inconclusive)

Check name Status Explanation Resolution
Test Structure And Quality ❓ Inconclusive The file referenced in the PR summary could not be located in the repository, preventing assessment of test quality and structure requirements. Verify the correct repository and branch are being analyzed, then examine the exceptions list additions to confirm they follow existing test patterns and codebase conventions.
Ote Binary Stdout Contract ❓ Inconclusive The file pkg/monitortests/authentication/nodefaultserviceaccountoperatortests/monitortest.go could not be located in the repository for analysis. Verify the repository contains the referenced file and provide access to the actual code changes for OTE Binary Stdout Contract compliance assessment.
✅ Passed checks (10 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The pull request does not contain any Ginkgo test declarations in the modified file. Changes add deterministic static prefix strings to an exceptions list.
Microshift Test Compatibility ✅ Passed This pull request does not add any new Ginkgo e2e tests. The changes only extend the exceptions list in an existing monitor test utility that implements the MonitorTest interface.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR does not add new Ginkgo e2e tests; it only extends the exceptions list in a monitor test framework implementation.
Topology-Aware Scheduling Compatibility ✅ Passed New test file adds namespace/pod exceptions with no scheduling implications for pod placement across OpenShift topologies.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR modifies a monitor test by adding exception matchers for pod namespaces, not adding Ginkgo e2e tests with IPv4 assumptions or external connectivity requirements.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding exceptions for managed cluster namespaces (openshift-route-monitor-operator and openshift-security) to the authentication monitor test.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from deads2k and sjenning April 28, 2026 03:18
@openshift-merge-bot openshift-merge-bot Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Apr 28, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@neisw
Copy link
Copy Markdown
Contributor

neisw commented Apr 28, 2026

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 28, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmeng, coderabbitai[bot], neisw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2026
@bmeng bmeng changed the title add exception for managed cluster namespaces [SREP-4676] add exception for managed cluster namespaces Apr 28, 2026
@bmeng
Copy link
Copy Markdown
Contributor Author

bmeng commented Apr 29, 2026

/retest

@bmeng bmeng changed the title [SREP-4676] add exception for managed cluster namespaces SREP-4676: add exception for managed cluster namespaces Apr 29, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 29, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 29, 2026

@bmeng: This pull request references SREP-4676 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Adding exception for the namespaces are only for managed clusters.

Each of the exception being tracked by JIRA card. Can remove them once the issue fixed in operators.

Fixes: SREP-4676

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bmeng
Copy link
Copy Markdown
Contributor Author

bmeng commented Apr 29, 2026

/verified will check in CI test

@openshift-ci-robot
Copy link
Copy Markdown

@bmeng: The /verified command must be used with one of the following actions: by, later, remove, or bypass. See https://docs.ci.openshift.org/docs/architecture/jira/#premerge-verification for more information.

Details

In response to this:

/verified will check in CI test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bmeng
Copy link
Copy Markdown
Contributor Author

bmeng commented Apr 29, 2026

/verified later @bmeng

@openshift-ci-robot
Copy link
Copy Markdown

@bmeng: This PR has been marked to be verified later by @bmeng.

Details

In response to this:

/verified later @bmeng

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 29, 2026
@bmeng
Copy link
Copy Markdown
Contributor Author

bmeng commented Apr 29, 2026

/test e2e-gcp-ovn-upgrade

@bmeng
Copy link
Copy Markdown
Contributor Author

bmeng commented Apr 29, 2026

/test e2e-gcp-ovn

@bmeng
Copy link
Copy Markdown
Contributor Author

bmeng commented Apr 29, 2026

/override ci/prow/e2e-gcp-ovn-upgrade

@bmeng
Copy link
Copy Markdown
Contributor Author

bmeng commented Apr 29, 2026

/override ci/prow/e2e-gcp-ovn

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 29, 2026

@bmeng: bmeng unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers openshift-sustaining-engineers.

Details

In response to this:

/override ci/prow/e2e-gcp-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 131c4f1 and 2 for PR HEAD 9ff5d70 in total

@openshift-trt
Copy link
Copy Markdown

openshift-trt Bot commented Apr 29, 2026

Job Failure Risk Analysis for sha: 9ff5d70

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-gcp-ovn-upgrade High
[Monitor:legacy-test-framework-invariants-pathological][sig-arch] events should not repeat pathologically for ns/openshift-multus
This test has passed 99.83% of 5211 runs on release 5.0 [Overall] in the last week.
---
[Monitor:legacy-test-framework-invariants-pathological][sig-arch] events should not repeat pathologically for ns/openshift-network-diagnostics
This test has passed 98.79% of 5211 runs on release 5.0 [Overall] in the last week.

@neisw
Copy link
Copy Markdown
Contributor

neisw commented Apr 29, 2026

/override ci/prow/e2e-gcp-ovn-upgrade

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 29, 2026

@neisw: Overrode contexts on behalf of neisw: ci/prow/e2e-gcp-ovn-upgrade

Details

In response to this:

/override ci/prow/e2e-gcp-ovn-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 29, 2026

@bmeng: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit eb25c46 into openshift:main Apr 29, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review verified Signifies that the PR passed pre-merge verification criteria verified-later

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants