Skip to content

OCPBUGS-84846: Fix NetworkNotReady pathological event regex case mismatch #31088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tsorya wants to merge 1 commit into
base: main
Choose a base branch
from
+27 −1
Open

OCPBUGS-84846: Fix NetworkNotReady pathological event regex case mismatch #31088

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_event_patterns.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,7 +615,7 @@ func NewUpgradePathologicalEventMatchers(kubeConfig *rest.Config, finalIntervals
registry.AddPathologicalEventMatcherOrDie(&SimplePathologicalEventMatcher{
name: "NetworkNotReady",
messageReasonRegex: regexp.MustCompile(`^NetworkNotReady$`),
messageHumanRegex: regexp.MustCompile(`network is not ready: container runtime network not ready: NetworkReady=false reason:NetworkPluginNotReady message:Network plugin returns error: No CNI configuration file.*Has your network provider started\?`),
messageHumanRegex: regexp.MustCompile(`network is not ready: container runtime network not ready: NetworkReady=false reason:NetworkPluginNotReady message:Network plugin returns error: [Nn]o CNI configuration file.*Has your network provider started\?`),
})

// Allow FailedScheduling repeat events during node upgrades:
Expand Down
26 changes: 26 additions & 0 deletions pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_events_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,32 @@ func TestAllowedRepeatedEvents(t *testing.T) {
Reason("SuccessfulCreate").Build(),
expectedAllowName: "PacemakerStatusCollectorCronJobEvents",
},
{
name: "NetworkNotReady with lowercase no from ocicni",
locator: monitorapi.Locator{
Keys: map[monitorapi.LocatorKey]string{
monitorapi.LocatorNamespaceKey: "openshift-multus",
monitorapi.LocatorPodKey: "network-metrics-daemon-4snn9",
monitorapi.LocatorNodeKey: "ip-10-0-124-97.us-west-1.compute.internal",
},
},
msg: monitorapi.NewMessage().HumanMessage("network is not ready: container runtime network not ready: NetworkReady=false reason:NetworkPluginNotReady message:Network plugin returns error: no CNI configuration file in /etc/kubernetes/cni/net.d/. Has your network provider started?").
Reason("NetworkNotReady").Build(),
expectedAllowName: "NetworkNotReady",
},
{
name: "NetworkNotReady with uppercase No",
locator: monitorapi.Locator{
Keys: map[monitorapi.LocatorKey]string{
monitorapi.LocatorNamespaceKey: "openshift-network-diagnostics",
monitorapi.LocatorPodKey: "network-check-target-pf5mx",
monitorapi.LocatorNodeKey: "ip-10-0-80-8.us-west-1.compute.internal",
},
},
msg: monitorapi.NewMessage().HumanMessage("network is not ready: container runtime network not ready: NetworkReady=false reason:NetworkPluginNotReady message:Network plugin returns error: No CNI configuration file in /etc/kubernetes/cni/net.d/. Has your network provider started?").
Reason("NetworkNotReady").Build(),
expectedAllowName: "NetworkNotReady",
},
}
for _, test := range tests {
registry := NewUpgradePathologicalEventMatchers(nil, nil)
Expand Down