Skip to content

[release-4.22] OCPBUGS-84654: fix openshift/network/third-party suite selecting zero tests#31090

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.22from
openshift-cherrypick-robot:cherry-pick-31084-to-release-4.22
May 1, 2026
Merged

[release-4.22] OCPBUGS-84654: fix openshift/network/third-party suite selecting zero tests#31090
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.22from
openshift-cherrypick-robot:cherry-pick-31084-to-release-4.22

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

This is an automated cherry-pick of #31084

/assign petr-muller

… tests

The openshift/network/third-party suite CEL qualifier used
name.contains("[Suite:k8s]") to identify upstream Kubernetes tests, but
no tests carry that tag after the OTE migration. Replace with
source == "openshift:payload:hyperkube" which is the correct way to
identify upstream k8s tests in the extension framework.

Add a semantic test that verifies the qualifier actually matches expected
test specs, preventing future regressions.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 29, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 845c887a-3fc1-4a4f-b144-041a332477c1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from deads2k and sjenning April 29, 2026 01:28
@openshift-ci-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot: Jira Issue OCPBUGS-84257 has been cloned as Jira Issue OCPBUGS-84654. Will retitle bug to link to clone.
/retitle [release-4.22] OCPBUGS-84654: fix openshift/network/third-party suite selecting zero tests

Details

In response to this:

This is an automated cherry-pick of #31084

/assign petr-muller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot changed the title [release-4.22] OCPBUGS-84257: fix openshift/network/third-party suite selecting zero tests [release-4.22] OCPBUGS-84654: fix openshift/network/third-party suite selecting zero tests Apr 29, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Apr 29, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-84654, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #31084

/assign petr-muller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 29, 2026
@petr-muller
Copy link
Copy Markdown
Member

/uncc @sjenning @deads2k

@openshift-ci openshift-ci Bot removed request for deads2k and sjenning April 29, 2026 12:25
@petr-muller
Copy link
Copy Markdown
Member

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown

@petr-muller: This pull request references Jira Issue OCPBUGS-84654, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@petr-muller
Copy link
Copy Markdown
Member

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 30, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@petr-muller: This pull request references Jira Issue OCPBUGS-84654, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-84257 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-84257 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
  • bug has dependents
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@petr-muller
Copy link
Copy Markdown
Member

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 30, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2026
@petr-muller
Copy link
Copy Markdown
Member

/test images

1 similar comment
@petr-muller
Copy link
Copy Markdown
Member

/test images

@petr-muller
Copy link
Copy Markdown
Member

petr-muller commented Apr 30, 2026

$ mkdir -p /tmp/ot-cache-fixed-422 && podman run --authfile ~/Downloads/pull-secret \
                      -v ~/Downloads/pull-secret:/tmp/pull-secret:z \
                      -v /tmp/kubeconfig-dryrun:/tmp/kubeconfig:z \
                      -v /tmp/ot-cache-fixed-422:/root/.cache/openshift-tests:z \
                      --rm \
                      -e REGISTRY_AUTH_FILE=/tmp/pull-secret \
                      -e KUBECONFIG=/tmp/kubeconfig \
                      -e EXTENSIONS_PAYLOAD_OVERRIDE=registry.build09.ci.openshift.org/ci-op-zvbsn1wy/release:latest \
                      registry.build09.ci.openshift.org/ci-op-zvbsn1wy/stable:tests \
                      openshift-tests run openshift/network/third-party --dry-run
I0430 23:21:51.242247       1 factory.go:195] Registered Plugin "containerd"
  I0430 23:21:51.256132       1 i18n.go:119] Couldn't find the LC_ALL, LC_MESSAGES or LANG environment variables, defaulting to en_US
  I0430 23:21:51.499686       1 binary.go:80] Found 8852 test specs
...
time="2026-04-30T23:21:55Z" level=info msg="Listed 0 tests in 13.495761ms" binary=openshift-apiserver-tests-ext
time="2026-04-30T23:21:55Z" level=info msg="Listed 0 tests in 11.425224ms" binary=openshift-controller-manager-tests-ext
time="2026-04-30T23:21:55Z" level=info msg="Listed 124 tests in 62.182425ms" binary=olmv1-tests-ext
time="2026-04-30T23:21:55Z" level=info msg="Listed 20 tests in 50.315192ms" binary=service-ca-operator-tests-ext
time="2026-04-30T23:21:55Z" level=info msg="Listed 208 tests in 69.437373ms" binary=olmv0-tests-ext
time="2026-04-30T23:21:55Z" level=info msg="Listed 112 tests in 122.772407ms" binary=machine-config-tests-ext
time="2026-04-30T23:21:55Z" level=info msg="Listed 0 tests in 296.245747ms" binary=machine-api-tests-ext
time="2026-04-30T23:21:55Z" level=info msg="Listed 1162 tests in 493.076915ms" binary=openshift-tests
time="2026-04-30T23:21:55Z" level=info msg="Listed 6863 tests in 488.250149ms" binary=k8s-tests-ext
time="2026-04-30T23:21:56Z" level=info msg="Listed 0 tests in 756.465176ms" binary=ovn-kubernetes-tests-ext
time="2026-04-30T23:21:56Z" level=info msg="Discovered 8640 total tests"
time="2026-04-30T23:21:56Z" level=info msg="Generated skips for cluster state" skips="[[Skipped:skeleton] [Feature:Networking-IPv4] [Feature:Networking-IPv6] [Feature:IPv6DualStack [Feature:SCTPConnectivity] [Requires:HypervisorSSHConfig]]"
time="2026-04-30T23:21:56Z" level=info msg="Applying filter: suite-qualifiers" before=8640 component=test-filter filter=suite-qualifiers
time="2026-04-30T23:21:56Z" level=info msg="Filter suite-qualifiers completed - removed 8537 tests" after=103 before=8640 component=test-filter filter=suite-qualifiers removed=8537
time="2026-04-30T23:21:56Z" level=info msg="Applying filter: kube-rebase-tests" before=103 component=test-filter filter=kube-rebase-tests
time="2026-04-30T23:21:57Z" level=info msg="Filter kube-rebase-tests completed - removed 0 tests" after=103 before=103 component=test-filter filter=kube-rebase-tests removed=0
time="2026-04-30T23:21:57Z" level=info msg="Applying filter: disabled-tests" before=103 component=test-filter filter=disabled-tests
time="2026-04-30T23:21:57Z" level=info msg="Filter disabled-tests completed - removed 0 tests" after=103 before=103 component=test-filter filter=disabled-tests removed=0
time="2026-04-30T23:21:57Z" level=info msg="Applying filter: cluster-state" before=103 component=test-filter filter=cluster-state
time="2026-04-30T23:21:57Z" level=info msg="Filter cluster-state completed - removed 26 tests" after=77 before=103 component=test-filter filter=cluster-state removed=26
time="2026-04-30T23:21:57Z" level=info msg="Filter chain completed with 77 tests" component=test-filter final_count=77
"[sig-network] API Server should have Endpoints and EndpointSlices pointing to API Server [Conformance]"
"[sig-network] API Server should provide secure master service [Conformance]"
"[sig-network] DNS should provide /etc/hosts entries for the cluster [Conformance]"
"[sig-network] DNS should provide DNS for ExternalName services [Conformance]"
"[sig-network] DNS should provide DNS for pods for Hostname [Conformance]"
...

/verified by @petr-muller

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 30, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@petr-muller: This PR has been marked as verified by @petr-muller.

Details

In response to this:

$ mkdir -p /tmp/ot-cache-fixed-422 && podman run --authfile ~/Downloads/pull-secret \
                     -v ~/Downloads/pull-secret:/tmp/pull-secret:z \
                     -v /tmp/kubeconfig-dryrun:/tmp/kubeconfig:z \
                     -v /tmp/ot-cache-fixed-422:/root/.cache/openshift-tests:z \
                     --rm \
                     -e REGISTRY_AUTH_FILE=/tmp/pull-secret \
                     -e KUBECONFIG=/tmp/kubeconfig \
                     -e EXTENSIONS_PAYLOAD_OVERRIDE=registry.build09.ci.openshift.org/ci-op-zvbsn1wy/release:latest \
                     registry.build09.ci.openshift.org/ci-op-zvbsn1wy/stable:tests \
                     openshift-tests run openshift/network/third-party --dry-run
I0430 23:21:51.242247       1 factory.go:195] Registered Plugin "containerd"
 I0430 23:21:51.256132       1 i18n.go:119] Couldn't find the LC_ALL, LC_MESSAGES or LANG environment variables, defaulting to en_US
 I0430 23:21:51.499686       1 binary.go:80] Found 8852 test specs
...
time="2026-04-30T23:21:55Z" level=info msg="Listed 0 tests in 13.495761ms" binary=openshift-apiserver-tests-ext
time="2026-04-30T23:21:55Z" level=info msg="Listed 0 tests in 11.425224ms" binary=openshift-controller-manager-tests-ext
time="2026-04-30T23:21:55Z" level=info msg="Listed 124 tests in 62.182425ms" binary=olmv1-tests-ext
time="2026-04-30T23:21:55Z" level=info msg="Listed 20 tests in 50.315192ms" binary=service-ca-operator-tests-ext
time="2026-04-30T23:21:55Z" level=info msg="Listed 208 tests in 69.437373ms" binary=olmv0-tests-ext
time="2026-04-30T23:21:55Z" level=info msg="Listed 112 tests in 122.772407ms" binary=machine-config-tests-ext
time="2026-04-30T23:21:55Z" level=info msg="Listed 0 tests in 296.245747ms" binary=machine-api-tests-ext
time="2026-04-30T23:21:55Z" level=info msg="Listed 1162 tests in 493.076915ms" binary=openshift-tests
time="2026-04-30T23:21:55Z" level=info msg="Listed 6863 tests in 488.250149ms" binary=k8s-tests-ext
time="2026-04-30T23:21:56Z" level=info msg="Listed 0 tests in 756.465176ms" binary=ovn-kubernetes-tests-ext
time="2026-04-30T23:21:56Z" level=info msg="Discovered 8640 total tests"
time="2026-04-30T23:21:56Z" level=info msg="Generated skips for cluster state" skips="[[Skipped:skeleton] [Feature:Networking-IPv4] [Feature:Networking-IPv6] [Feature:IPv6DualStack [Feature:SCTPConnectivity] [Requires:HypervisorSSHConfig]]"
time="2026-04-30T23:21:56Z" level=info msg="Applying filter: suite-qualifiers" before=8640 component=test-filter filter=suite-qualifiers
time="2026-04-30T23:21:56Z" level=info msg="Filter suite-qualifiers completed - removed 8537 tests" after=103 before=8640 component=test-filter filter=suite-qualifiers removed=8537
time="2026-04-30T23:21:56Z" level=info msg="Applying filter: kube-rebase-tests" before=103 component=test-filter filter=kube-rebase-tests
time="2026-04-30T23:21:57Z" level=info msg="Filter kube-rebase-tests completed - removed 0 tests" after=103 before=103 component=test-filter filter=kube-rebase-tests removed=0
time="2026-04-30T23:21:57Z" level=info msg="Applying filter: disabled-tests" before=103 component=test-filter filter=disabled-tests
time="2026-04-30T23:21:57Z" level=info msg="Filter disabled-tests completed - removed 0 tests" after=103 before=103 component=test-filter filter=disabled-tests removed=0
time="2026-04-30T23:21:57Z" level=info msg="Applying filter: cluster-state" before=103 component=test-filter filter=cluster-state
time="2026-04-30T23:21:57Z" level=info msg="Filter cluster-state completed - removed 26 tests" after=77 before=103 component=test-filter filter=cluster-state removed=26
time="2026-04-30T23:21:57Z" level=info msg="Filter chain completed with 77 tests" component=test-filter final_count=77
"[sig-network] API Server should have Endpoints and EndpointSlices pointing to API Server [Conformance]"
"[sig-network] API Server should provide secure master service [Conformance]"
"[sig-network] DNS should provide /etc/hosts entries for the cluster [Conformance]"
"[sig-network] DNS should provide DNS for ExternalName services [Conformance]"
"[sig-network] DNS should provide DNS for pods for Hostname [Conformance]"

/verified by @petr-muller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@stbenjam
Copy link
Copy Markdown
Member

stbenjam commented May 1, 2026

/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 1, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 1, 2026

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 824a1e1 into openshift:release-4.22 May 1, 2026
8 checks passed
@openshift-ci-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-84654
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-84654 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

This is an automated cherry-pick of #31084

/assign petr-muller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot
Copy link
Copy Markdown
Contributor

Fix included in release 4.22.0-0.nightly-2026-05-01-132406

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.