OCPCLOUD-3429: Ignore excessive image volume events from CAPI operator

[mdbooth]

Required until a fix for
kubernetes/kubernetes#138644 lands.

Tracked in https://redhat.atlassian.net/browse/OCPBUGS-84659.

Summary by CodeRabbit

• Bug Fixes
  • Enhanced event monitoring to properly handle repeated image volume presence events as expected system behavior, preventing unnecessary alerts and reducing false positives in cluster monitoring.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci-robot]

@mdbooth: This pull request references OCPCLOUD-3429 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Required until a fix for
kubernetes/kubernetes#138644 lands.

Tracked in https://redhat.atlassian.net/browse/OCPBUGS-84659.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: afc5f968-9ebf-487d-9c34-9fb34f55814b

📥 Commits

Reviewing files that changed from the base of the PR and between 131c4f1 and e18ff74.

📒 Files selected for processing (1)

• pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_event_patterns.go

---

Walkthrough

A new pathological-event matcher is added to treat repeated kubelet "Pulled" events related to image volume presence as benign. The matcher targets the openshift-cluster-api-operator namespace and capi-operator-* pods, using regex pattern matching on event reasons and messages.

Changes

Cohort / File(s)	Summary
Event Matcher Addition pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_event_patterns.go	Added new matcher for handling duplicate kubelet "Pulled" events in cluster API operator namespace, with regex-based filtering and steady-state detection.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: adding logic to ignore excessive image volume events from the CAPI operator.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR adds static event matcher configuration with deterministic name and patterns to library file; no Ginkgo tests present.
Test Structure And Quality	✅ Passed	PR modifies only production code in duplicated_event_patterns.go with no test file changes, making Ginkgo test quality check not applicable.
Microshift Test Compatibility	✅ Passed	This pull request does not add any new Ginkgo e2e tests. The modification is to a library file that adds a pathological event matcher configuration, which contains no Ginkgo test definitions.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR modifies pathological event matcher configuration without adding Ginkgo e2e test definitions, so custom check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	PR modifies event pattern matching library for monitoring; introduces no scheduling constraints, pod affinity rules, or topology-specific deployment changes affecting SNO, Two-Node, or HyperShift.
Ote Binary Stdout Contract	✅ Passed	Code registers pathological event matcher during test execution, not process initialization. No stdout writes occur; logrus logging uses stderr during tests, not binary startup, preserving OTE stdout contract.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR does not add any new Ginkgo e2e tests; it only modifies a configuration file that defines pathological event matchers for the monitoring/testing framework.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Review rate limit: 9/10 reviews remaining, refill in 6 minutes.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[neisw]

/testwith openshift/origin/main/e2e-aws-ovn-techpreview openshift/cluster-capi-operator#527

[openshift-ci]

@neisw, testwith: could not generate prow job. ERROR:

BUG: test 'e2e-aws-ovn-techpreview' not found in injected config

[neisw]

/testwith openshift/cluster-capi-operator/main/e2e-aws-ovn-techpreview openshift/cluster-capi-operator#527

[neisw]

/test ?

[neisw]

/testwith openshift/origin/main/e2e-gcp-ovn-techpreview openshift/cluster-capi-operator#527

[neisw]

/payload-job-with-prs periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn-techpreview openshift/cluster-capi-operator#527

[openshift-ci]

@neisw: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b13a31d0-43c7-11f1-9617-3c9ef15215d6-0

[neisw]

/lgtm

based on https://prow.ci.openshift.org/view/gs/test-platform-results/logs/openshift-cluster-capi-operator-527-openshift-origin-31093-ci-5.0-e2e-aws-ovn-techpreview/2049467349571997696

[neisw]

/retest-required

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coderabbitai[bot], mdbooth, neisw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [neisw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[neisw]

/override ci/prow/e2e-gcp-ovn-upgrade

[openshift-ci]

@neisw: Overrode contexts on behalf of neisw: ci/prow/e2e-gcp-ovn-upgrade

Details

In response to this:

/override ci/prow/e2e-gcp-ovn-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-trt]

Job Failure Risk Analysis for sha: e18ff74

Job Name	Failure Risk
pull-ci-openshift-origin-main-e2e-gcp-ovn-upgrade	Medium [Monitor:node-lifecycle][sig-node] node-lifecycle detects unexpected not ready node This test has passed 94.82% of 5193 runs on release 5.0 [Overall] in the last week.

[mdbooth]

/verified by CI run against openshift/cluster-capi-operator#527

[openshift-ci-robot]

@mdbooth: This PR has been marked as verified by CI run against https://github.com/openshift/cluster-capi-operator/pull/527.

Details

In response to this:

/verified by CI run against openshift/cluster-capi-operator#527

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@mdbooth: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.