OCPSTRAT-3036: Update etcd test data for k8s 1.36 release by jubittajohn · Pull Request #31113 · openshift/origin

jubittajohn · 2026-05-01T22:46:21Z

Summary by CodeRabbit

Tests
- Enhanced etcd storage path tests: added entries for new API resources (mutating admission policies, podgroups, device taint rules, resourcepool status), adjusted version introduce/remove ranges, and updated expected registry paths; modified existing entries for storage volume classes and scheduling workloads to validate version and path changes.

openshift-merge-bot · 2026-05-01T22:46:24Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

openshift-ci-robot · 2026-05-01T22:46:26Z

@jubittajohn: This pull request references OCPSTRAT-3036 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-05-01T22:46:40Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 34f7d53f-7a92-42c6-a75a-654aa5915302

📥 Commits

Reviewing files that changed from the base of the PR and between 94577bf and 8ad6655.

📒 Files selected for processing (1)

test/extended/etcd/etcd_storage_path.go

🚧 Files skipped from review as they are similar to previous changes (1)

test/extended/etcd/etcd_storage_path.go

Walkthrough

Update to the etcd storage path test (1.36 branch) that adds and modifies expected etcd registry entries and version metadata for mutating admission policies/bindings, scheduling podgroups/workloads, storage volumeattributesclasses, and several resource.k8s.io kinds.

Changes

etcd Storage Test Data

Layer / File(s)	Summary
Added etcd data `test/extended/etcd/etcd_storage_path.go`	New "Added etcd data" entries for admissionregistration.k8s.io mutatingadmissionpolicies & bindings (GVR v1, ExpectedGVK pinned to v1beta1, IntroducedVersion "1.36"), scheduling.k8s.io podgroups (Introduced "1.36", Removed "1.42"), resource.k8s.io devicetaintrules (GVR v1beta2, ExpectedGVK overridden to resource.k8s.io/v1alpha3 DeviceTaintRule, Introduced "1.36", Removed "1.42"), and resourcepoolstatusrequests (Introduced "1.36", Removed "1.42") with explicit expected etcd paths.
Modified etcd data `test/extended/etcd/etcd_storage_path.go`	Updated "Modified etcd data" entries: storage.k8s.io volumeattributesclasses (v1beta1 vac2 Introduced "1.31" Removed "1.37"; v1 vac3 Introduced "1.34"), scheduling.k8s.io workloads (Introduced "1.36" Removed "1.42"), and admissionregistration.k8s.io v1beta1 mutatingadmissionpolicies/bindings (map1b1/mpb1b1 Introduced "1.34" Removed "1.40") with revised expected etcd registry paths.
Test metadata / context `test/extended/etcd/etcd_storage_path.go`	All additions/updates are placed under the `strings.HasPrefix(version.Minor, "36")` branch of `testEtcd3StoragePath`, adjusting test expectations and version ranges for the 1.36 test matrix.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly and clearly summarizes the main change: updating etcd test data to support Kubernetes 1.36 release, which matches the file modifications and added test data entries.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR adds static test data without modifying any Ginkgo test titles. The dynamic g.By() call is a step annotation for logging, not a test title.
Test Structure And Quality	✅ Passed	PR modifies only test fixture data in testEtcd3StoragePath, adding entries for Kubernetes 1.36 resource types without new test cases or assertion code.
Microshift Test Compatibility	✅ Passed	This pull request does not add new Ginkgo e2e tests; it only modifies test data within the existing testEtcd3StoragePath() function for Kubernetes 1.36 support.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This pull request modifies test data within an existing helper function and does not add any new Ginkgo e2e tests.
Topology-Aware Scheduling Compatibility	✅ Passed	Pull request modifies only test data in test/extended/etcd/etcd_storage_path.go, adding entries to map test fixtures for Kubernetes 1.36 API objects. The file contains no deployment manifests, operator code, controllers, or scheduling constraints. Change falls entirely outside topology-aware scheduling compatibility scope.
Ote Binary Stdout Contract	✅ Passed	PR modifies only test file with declarative data additions in test function. No stdout-writing operations at process level; proper Ginkgo patterns ensure framework interception.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Pull request only adds test data to existing testEtcd3StoragePath function; no new Ginkgo test blocks (It, Describe, Context, When) are introduced.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Review rate limit: 9/10 reviews remaining, refill in 6 minutes.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@test/extended/etcd/etcd_storage_path.go`:
- Around line 307-312: There are two entries for gvr("scheduling.k8s.io",
"v1alpha2", "podgroups") causing the first
stub/ExpectedEtcdPath/IntroducedVersion/RemovedVersion set to be silently
overridden; remove the duplicate so only one canonical definition remains.
Locate both occurrences of gvr("scheduling.k8s.io", "v1alpha2", "podgroups") and
keep the intended stub/ExpectedEtcdPath/IntroducedVersion/RemovedVersion set
(pick which stub you want exercised), deleting the other entry to ensure the
test uses a single, unambiguous podgroups definition.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: fc87181b-f9a5-4916-9a07-74a35cb791d6

📥 Commits

Reviewing files that changed from the base of the PR and between 046ab17 and 94577bf.

📒 Files selected for processing (1)

test/extended/etcd/etcd_storage_path.go

openshift-merge-bot · 2026-05-01T23:12:34Z

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

Signed-off-by: jubittajohn <jujohn@redhat.com>

openshift-merge-bot · 2026-05-02T01:33:40Z

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

openshift-ci · 2026-05-04T03:41:34Z