NO-JIRA: Tolerate events during the vSphere CSI driver removal test

[jsafrane]

Test "vSphere CSI Driver Operator Removal" un-installs the CSI driver + installs it back. I.e. a DaemonSet and two Deployment are deleted + re-created with many events like "Created pod: vmware-vsphere-csi-driver-node-tkl25"

See openshift/vmware-vsphere-csi-driver-operator#337 that adds the test + a rehearsal result

Summary by CodeRabbit

• Tests
  • Expanded test interval detection to identify additional vSphere CSI Driver configuration test scenarios, improving monitoring coverage for related testing workflows.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci-robot]

@jsafrane: This pull request explicitly references no jira issue.

Details

In response to this:

Test "vSphere CSI Driver Operator Removal" un-installs the CSI driver + installs it back. I.e. a DaemonSet and two Deployment with many events like "Created pod: vmware-vsphere-csi-driver-node-tkl25"

See openshift/vmware-vsphere-csi-driver-operator#337 that adds the test + a rehearsal result

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: d6aaaaf7-9eb9-474a-bd6c-b97885a88120

📥 Commits

Reviewing files that changed from the base of the PR and between 954d227 and 47b699f.

📒 Files selected for processing (1)

• pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_event_patterns.go

---

Walkthrough

The change expands pattern matching logic in an E2E test event filter by adding a second substring to match alongside the existing one when identifying vSphere-related configuration test intervals.

Changes

vSphere Configuration Test Matcher Expansion

Layer / File(s)	Summary
Pattern Matching Logic pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_event_patterns.go	newVsphereConfigurationTestsRollOutTooOftenEventMatcher now matches SourceE2ETest intervals whose LocatorE2ETestKey contains either "snapshot options in clusterCSIDriver" or "vSphere CSI Driver Operator Removal", expanding from the prior single hardcoded substring.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly describes the main change: adding tolerance for events during the vSphere CSI driver removal test, which matches the core objective of the PR.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR modifies event matching patterns, not Ginkgo test titles. No test definitions present. Added strings are static filter patterns without dynamic information.
Test Structure And Quality	✅ Passed	Custom check targets Ginkgo test quality. PR modifies only a library configuration file, not any Ginkgo tests.
Microshift Test Compatibility	✅ Passed	This PR does not add new Ginkgo e2e tests. It modifies an event matching utility library to tolerate events during an existing test. The check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No new Ginkgo e2e tests added. The PR only modifies event filtering/matching code (duplicated_event_patterns.go) to tolerate events from an existing test in a separate upstream repository.
Topology-Aware Scheduling Compatibility	✅ Passed	Not applicable. PR modifies only a test event monitoring library (pathologicaleventlibrary), not deployment manifests, operator code, or controllers. No scheduling constraints are introduced.
Ote Binary Stdout Contract	✅ Passed	The PR updates test event pattern matching logic. No process-level stdout writes, no fmt.Print calls, and logrus only. Safe for OTE Binary Stdout Contract.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR does not add new Ginkgo e2e tests. It only modifies event tolerance library code. Check is not applicable.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jsafrane
Once this PR has been reviewed and has the lgtm label, please assign mkowalski for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@jsafrane: This PR was included in a payload test run from openshift/vmware-vsphere-csi-driver-operator#337
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-5.0-e2e-vsphere-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/feb5b540-4879-11f1-9b84-0bd24eaf093f-0

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[openshift-ci]

@jsafrane: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6	47b699f	link	true	/test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.