Skip to content

NO-JIRA: Fix flaky storage-admin e2e test #31180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jubittajohn wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −5
Open

NO-JIRA: Fix flaky storage-admin e2e test #31180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions test/extended/cli/admin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,20 +301,21 @@ var _ = g.Describe("[sig-cli] oc adm", func() {
o.Expect(out).To(o.ContainSubstring(`cannot list resource "rolebindings" in API group "rbac.authorization.k8s.io"`))

g.By("Test that scoped storage-admin now an admin in project foo")
o.Expect(oc.Run("new-project").Args("--skip-config-write=true", "--as=storage-adm2", "--as-group=system:authenticated:oauth", "--as-group=sytem:authenticated", "policy-can-i").Execute()).NotTo(o.HaveOccurred())
projectName := names.SimpleNameGenerator.GenerateName("policy-can-i-")
o.Expect(oc.Run("new-project").Args("--skip-config-write=true", "--as=storage-adm2", "--as-group=system:authenticated:oauth", "--as-group=system:authenticated", projectName).Execute()).NotTo(o.HaveOccurred())
defer func() {
oc.Run("delete").Args("project/policy-can-i").Execute()
oc.Run("delete").Args("project/" + projectName).Execute()
}()

out, err = oc.Run("auth", "can-i").Args("--namespace=policy-can-i", "--as=storage-adm2", "create", "pod", "--all-namespaces").Output()
out, err = oc.Run("auth", "can-i").Args("--namespace="+projectName, "--as=storage-adm2", "create", "pod", "--all-namespaces").Output()
o.Expect(err).To(o.HaveOccurred())
o.Expect(out).To(o.HaveSuffix("no"))

out, err = oc.Run("auth", "can-i").Args("--namespace=policy-can-i", "--as=storage-adm2", "create", "pod").Output()
out, err = oc.Run("auth", "can-i").Args("--namespace="+projectName, "--as=storage-adm2", "create", "pod").Output()
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(out).To(o.HaveSuffix("yes"))

out, err = oc.Run("auth", "can-i").Args("--namespace=policy-can-i", "--as=storage-adm2", "create", "pvc").Output()
out, err = oc.Run("auth", "can-i").Args("--namespace="+projectName, "--as=storage-adm2", "create", "pvc").Output()
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(out).To(o.HaveSuffix("yes"))
})
Expand Down