OCPBUGS-85363: Fixed flakiness of oc set image E2E tests#31191
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
@YamunadeviShanmugam: This pull request references Jira Issue OCPBUGS-85363, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
WalkthroughThis PR introduces a new ChangesCLI Image Resolution with Digest Discovery
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 10 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (10 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/jira refresh |
|
@YamunadeviShanmugam: This pull request references Jira Issue OCPBUGS-85363, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Scheduling required tests: |
|
/retest |
|
/lgtm |
|
@gangwgr: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gangwgr, sosiouxme, YamunadeviShanmugam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@YamunadeviShanmugam: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@YamunadeviShanmugam: Jira Issue Verification Checks: Jira Issue OCPBUGS-85363 Jira Issue OCPBUGS-85363 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Followup of #31152
c set image e2e test fails consistently in CI due to a dependency on the ImageStream. The test attempts to use the ruby:3.3-ubi8 ImageStream, which must be imported from an external registry. If the Samples Operator is disabled, or external network access is restricted or slow the tests starts failing introducing flakiness in the tests. The test enters a retry loop waiting for the image metadata to populate and hits a 2-minute timeout
Modified the tests to use a Payload Image instead of a sample image. By switching to a payload-backed reference, the test eliminates external dependencies and avoids synchronization delays, and the flakiness will be removed.
Testing
Before Fix
imagestream.image.openshift.io/wildfly created
STEP: waiting for created resources to be ready for testing @ 05/10/26 11:20:31.866
I0510 11:20:33.025181 2599393 client.go:1094] Error running oc --namespace=e2e-test-oc-set-image-2j5qn --kubeconfig=/tmp/configfile1940459752 get imagestreamtags ruby:3.3-ubi8:
StdOut>
Error from server (NotFound): imagestreamtags.image.openshift.io "ruby:3.3-ubi8" not found
StdErr>
Error from server (NotFound): imagestreamtags.image.openshift.io "ruby:3.3-ubi8" not found
Error from server (NotFound): imagestreamtags.image.openshift.io "ruby:3.3-ubi8" not found
NAME IMAGE REFERENCE UPDATED
ruby:3.3-ubi8 image-registry.openshift-image-registry.svc:5000/e2e-test-oc-set-image-2j5qn/ruby@sha256:0dab4f10d5038f00f4eaa6167ab75ec3dec9928ca2d9e77606ff39dfb4749854 2 seconds ago
STEP: testing --local flag validation @ 05/10/26 11:20:35.013
I0510 11:20:35.112917 2599393 client.go:1094] Error running oc --namespace=e2e-test-oc-set-image-2j5qn --k
After Fix
As the new tests will work on air-gapped clusters as well, removed the skipped:disconnected in the test
Summary by CodeRabbit