OCPBUGS-59500: pathologicalevents: fix HPA FailedGetResourceMetric allowlist

[eggfoobar]

The PodAutoscalerFailedToGetCPUUtilization matcher never matched real events because it treated horizontalpodautoscaler as the namespace key. Match openshift-ingress and e2e HPA conformance namespaces, and require FailedGetResourceMetric so Gateway API istiod HPAs stop failing the pathological events monitor during upgrade.

Summary by CodeRabbit

• Tests
  • Updated pod autoscaler failure detection patterns to monitor expanded namespace coverage, including ingress and test environments.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci-robot]

@eggfoobar: This pull request references Jira Issue OCPBUGS-59500, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (nhamza@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

The PodAutoscalerFailedToGetCPUUtilization matcher never matched real events because it treated horizontalpodautoscaler as the namespace key. Match openshift-ingress and e2e HPA conformance namespaces, and require FailedGetResourceMetric so Gateway API istiod HPAs stop failing the pathological events monitor during upgrade.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[eggfoobar]

/payload-aggregate periodic-ci-openshift-release-main-ci-5.0-e2e-aws-upgrade-ovn-single-node 10

[openshift-ci]

@eggfoobar: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-5.0-e2e-aws-upgrade-ovn-single-node

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f8efe1d0-58c8-11f1-9d5f-0cfdeb042717-0

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 057b87cc-51b7-4e62-af7b-34d1962415e7

📥 Commits

Reviewing files that changed from the base of the PR and between 1325193 and 0c43264.

📒 Files selected for processing (1)

• pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_event_patterns.go

---

Walkthrough

This PR updates a pathological event matcher used in monitoring tests. The PodAutoscalerFailedToGetCPUUtilization event detector now targets openshift-ingress and e2e-* namespaces instead of horizontalpodautoscaler, while maintaining the same failure reason and error message matching criteria.

Changes

CPU Utilization Event Matcher

Layer / File(s)	Summary
Namespace pattern update for CPU utilization matcher pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_event_patterns.go	The PodAutoscalerFailedToGetCPUUtilization matcher's LocatorNamespaceKey regex is updated from horizontalpodautoscaler to `^(openshift-ingress

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically references the fix being made (HPA FailedGetResourceMetric allowlist) and relates directly to the core change of updating the pathological event matcher's namespace filtering.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR modifies pathological event matchers in a non-test source file; no Ginkgo tests exist in modified files, and no dynamic test names are introduced.
Test Structure And Quality	✅ Passed	No Ginkgo tests present in PR. Tests use standard Go testing (testing.T) with testify assertions, not Ginkgo framework (no Describe/It/BeforeEach patterns found).
Microshift Test Compatibility	✅ Passed	PR modifies a pathological event library file (non-test), not adding any new Ginkgo e2e tests. Check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR modifies event matcher library, not Ginkgo e2e tests. File contains no test patterns and is not an e2e test file.
Topology-Aware Scheduling Compatibility	✅ Passed	This PR modifies a testing library file to update event matching patterns, not deployment manifests or operator code. No scheduling constraints are introduced.
Ote Binary Stdout Contract	✅ Passed	Library file contains only data-level changes (regex pattern update). No process-level stdout writes, fmt.Print calls, klog misconfigurations, or JSON corruption risks detected.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No Ginkgo e2e tests added. Change only updates pathological event matcher configuration in a library file, not a test file.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@eggfoobar: This pull request references Jira Issue OCPBUGS-59500, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (nhamza@redhat.com), skipping review request.

Details

In response to this:

The PodAutoscalerFailedToGetCPUUtilization matcher never matched real events because it treated horizontalpodautoscaler as the namespace key. Match openshift-ingress and e2e HPA conformance namespaces, and require FailedGetResourceMetric so Gateway API istiod HPAs stop failing the pathological events monitor during upgrade.

Summary by CodeRabbit

• Tests
• Updated pod autoscaler failure detection patterns to monitor expanded namespace coverage, including ingress and test environments.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[eggfoobar]

/verified by CI

None of the 3 agg jobs that failed, failed because of this pathological event, and they show that the event still gets triggered but correctly gets accounted for by this snippet instead of not triggering.

[openshift-ci-robot]

@eggfoobar: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

None of the 3 agg jobs that failed, failed because of this pathological event, and they show that the event still gets triggered but correctly gets accounted for by this snippet instead of not triggering.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[xueqzhan]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eggfoobar, xueqzhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [xueqzhan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@eggfoobar: Jira Issue Verification Checks: Jira Issue OCPBUGS-59500
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-59500 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

The PodAutoscalerFailedToGetCPUUtilization matcher never matched real events because it treated horizontalpodautoscaler as the namespace key. Match openshift-ingress and e2e HPA conformance namespaces, and require FailedGetResourceMetric so Gateway API istiod HPAs stop failing the pathological events monitor during upgrade.

Summary by CodeRabbit

• Tests
• Updated pod autoscaler failure detection patterns to monitor expanded namespace coverage, including ingress and test environments.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.