Skip to content

CORENET-7206: Register multus-cni OTE test extension binary#31231

Open
anuragthehatter wants to merge 1 commit into
openshift:mainfrom
anuragthehatter:multus-cni-test-extension
Open

CORENET-7206: Register multus-cni OTE test extension binary#31231
anuragthehatter wants to merge 1 commit into
openshift:mainfrom
anuragthehatter:multus-cni-test-extension

Conversation

@anuragthehatter
Copy link
Copy Markdown

@anuragthehatter anuragthehatter commented May 28, 2026

Summary

Test plan

  • Verify CI builds successfully
  • Use /testwith openshift/multus-cni#303 to validate end-to-end

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Tests
    • Added support for testing the multus-cni extension to enhance test coverage and validation capabilities.

Add multus-cni-tests-ext.gz to the extension binary registry
so openshift-tests discovers and runs multus-cni test cases.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 28, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: f786c0a1-ad53-467c-8725-37995a0e3c0a

📥 Commits

Reviewing files that changed from the base of the PR and between a29f970 and 35ee940.

📒 Files selected for processing (1)
  • pkg/test/extensions/binary.go

Walkthrough

This pull request extends the test extension binaries registry in pkg/test/extensions/binary.go with a new entry for the multus-cni image tag, mapping it to the external test binary path /usr/bin/multus-cni-tests-ext.gz.

Changes

Multus-cni test binary registration

Layer / File(s) Summary
Multus-cni test binary registry entry
pkg/test/extensions/binary.go
Registers the multus-cni test binary in the extensionBinaries registry, mapping the image tag to the external test binary path for test discovery and execution.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Ipv6 And Disconnected Network Test Compatibility ⚠️ Warning New test in multus.go hardcodes IPv4 CIDR "10.10.0.1/24" (line 51) without IPv6 adaptation. Test fixture also only configures IPv4. Will fail in IPv6-only clusters. Use GetIPAddressFamily() to detect cluster IP family and adapt test, or wrap with InIPv4ClusterContext(). Update bridge-nad.yml fixture to support both IPv4 and IPv6 addresses.
Ote Binary Stdout Contract ❓ Inconclusive PR only registers binary path; actual multus-cni binary code exists in external openshift/multus-cni PR#303. Cannot verify OTE stdout contract compliance without access to external binary source code. Check multus-cni PR#303 binary code for OTE stdout contract violations (unredirected klog/fmt.Print in main/init/TestMain/BeforeSuite/AfterSuite).
✅ Passed checks (13 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: registering the multus-cni OTE test extension binary in the extensions registry.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR adds only static registry entry (multus-cni binary mapping) to pkg/test/extensions/binary.go. No Ginkgo test declarations exist in changed files, so check is not applicable.
Test Structure And Quality ✅ Passed PR makes a simple registry entry addition (+4/-0) to binary.go, not Ginkgo test code. Custom check for test structure/quality is not applicable to this configuration change.
Microshift Test Compatibility ✅ Passed No new Ginkgo e2e tests are added to this repository. The PR only registers an external binary path in the extensionBinaries registry to discover tests from the multus-cni repository.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR adds only a registry entry for an external test binary (multus-cni) without introducing any direct Ginkgo test definitions in the codebase. SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR only adds a test binary registry entry. No deployment manifests, operators, controllers, or scheduling constraints are introduced.
No-Weak-Crypto ✅ Passed The PR adds only a registry entry for multus-cni with no weak cryptographic algorithms, custom crypto implementations, or unsafe secret comparisons.
Container-Privileges ✅ Passed PR only adds a registry entry for multus-cni test binary in binary.go. No container/K8s manifests, privileged settings, capabilities, or security contexts are introduced or modified.
No-Sensitive-Data-In-Logs ✅ Passed The multus-cni registry entry contains only standard binary path and image tag identifiers with no sensitive data like passwords, tokens, or credentials exposed in any logging.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@anuragthehatter anuragthehatter changed the title Register multus-cni OTE test extension binary CORENET-7206: Register multus-cni OTE test extension binary May 28, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 28, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 28, 2026

@anuragthehatter: This pull request references CORENET-7206 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

Test plan

  • Verify CI builds successfully
  • Use /testwith openshift/multus-cni#303 to validate end-to-end

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 28, 2026

Actionable comments posted: 0

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 28, 2026

@anuragthehatter: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn 35ee940 link true /test e2e-gcp-ovn
ci/prow/e2e-gcp-csi 35ee940 link true /test e2e-gcp-csi
ci/prow/e2e-aws-ovn-microshift 35ee940 link true /test e2e-aws-ovn-microshift
ci/prow/e2e-aws-ovn-fips 35ee940 link true /test e2e-aws-ovn-fips
ci/prow/e2e-aws-ovn-serial-2of2 35ee940 link true /test e2e-aws-ovn-serial-2of2
ci/prow/e2e-gcp-ovn-upgrade 35ee940 link true /test e2e-gcp-ovn-upgrade
ci/prow/e2e-vsphere-ovn-upi 35ee940 link true /test e2e-vsphere-ovn-upi
ci/prow/e2e-vsphere-ovn 35ee940 link true /test e2e-vsphere-ovn
ci/prow/e2e-aws-ovn-serial-1of2 35ee940 link true /test e2e-aws-ovn-serial-1of2
ci/prow/e2e-aws-ovn-microshift-serial 35ee940 link true /test e2e-aws-ovn-microshift-serial
ci/prow/e2e-metal-ipi-ovn-ipv6 35ee940 link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-csi 35ee940 link true /test e2e-aws-csi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants