Skip to content

Revert "CLID-589: add oc-mirror to extensionBinaries"#31238

Merged
stbenjam merged 1 commit into
openshift:mainfrom
redhat-chai-bot:05302153-bot-changes
May 30, 2026
Merged

Revert "CLID-589: add oc-mirror to extensionBinaries"#31238
stbenjam merged 1 commit into
openshift:mainfrom
redhat-chai-bot:05302153-bot-changes

Conversation

@redhat-chai-bot
Copy link
Copy Markdown
Contributor

@redhat-chai-bot redhat-chai-bot commented May 30, 2026

Revert "CLID-589: add oc-mirror to extensionBinaries"

This reverts merge commit bc9737b (PR #31006).

Why

The oc-mirror payload image does not contain oc-mirror-tests-ext.gz. Adding oc-mirror to extensionBinaries causes openshift-tests to fatally error at startup when it tries to extract this missing binary, before any tests can run.

Impact: 13 of 16 blocking jobs fail across all platforms. 3 consecutive 5.0 amd64 nightly payloads rejected. 23+ hours since last accepted payload.

What changed

Removes the oc-mirror entry from the extensionBinaries list in pkg/test/extensions/binary.go.

References

/cc @adolfo-ab

Summary by CodeRabbit

  • Updates
    • Removed support for the oc-mirror extension binary
    • Added support for the service-ca-operator extension binary

This reverts merge commit bc9737b (PR openshift#31006).

The oc-mirror payload image does not contain oc-mirror-tests-ext.gz,
causing openshift-tests to fatally error at startup. This broke 13 of
16 blocking jobs across all platforms, resulting in 3 consecutive
5.0 nightly payload rejections.
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci openshift-ci Bot requested a review from adolfo-ab May 30, 2026 22:05
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 30, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 30, 2026

@redhat-chai-bot: This pull request references CLID-589 which is a valid jira issue.

Details

In response to this:

Revert "CLID-589: add oc-mirror to extensionBinaries"

This reverts merge commit bc9737b (PR #31006).

Why

The oc-mirror payload image does not contain oc-mirror-tests-ext.gz. Adding oc-mirror to extensionBinaries causes openshift-tests to fatally error at startup when it tries to extract this missing binary, before any tests can run.

Impact: 13 of 16 blocking jobs fail across all platforms. 3 consecutive 5.0 amd64 nightly payloads rejected. 23+ hours since last accepted payload.

What changed

Removes the oc-mirror entry from the extensionBinaries list in pkg/test/extensions/binary.go.

References

/cc @adolfo-ab

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label May 30, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 4244696f-f800-4065-a0f3-bcac67ab1ea0

📥 Commits

Reviewing files that changed from the base of the PR and between 659c9b2 and 3c7c6bb.

📒 Files selected for processing (1)
  • pkg/test/extensions/binary.go
💤 Files with no reviewable changes (1)
  • pkg/test/extensions/binary.go

Walkthrough

The extensionBinaries registry is updated by removing the oc-mirror external test binary entry and adding the service-ca-operator entry, changing which extension payload binaries are discovered and extracted.

Changes

Extension binary registry update

Layer / File(s) Summary
Binary registry entry update
pkg/test/extensions/binary.go
The oc-mirror external binary entry in the extensionBinaries slice is replaced with a service-ca-operator entry, updating which binaries are available for extraction and testing.

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: reverting the addition of oc-mirror to extensionBinaries, which is the core action performed in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed File binary.go contains no Ginkgo test declarations (It, Describe, Context, When). It is a utility module managing test binary registry entries with only static string values. Check is not applicable.
Test Structure And Quality ✅ Passed The PR only modifies pkg/test/extensions/binary.go, which contains extension binary registry configuration code, not Ginkgo test code. The custom check is not applicable to non-test code.
Microshift Test Compatibility ✅ Passed No Ginkgo e2e tests were added in this PR. The changes are to the extensionBinaries registry in binary.go, which is infrastructure code that manages test binary extraction, not test definitions.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR does not add new Ginkgo e2e tests; it only modifies the extensionBinaries registry configuration in a utility file. Custom check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR removes oc-mirror entry from test binary registry; doesn't introduce deployment manifests, operator code, or scheduling constraints, so topology-aware check is not applicable.
Ote Binary Stdout Contract ✅ Passed PR removes oc-mirror entry from extensionBinaries (4 lines). No new code is added (+0 lines), so no new stdout writes in process-level code can be introduced. Satisfies OTE Binary Stdout Contract.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR contains no new Ginkgo e2e tests. It only reverts a configuration change to the extensionBinaries registry in pkg/test/extensions/binary.go, which is infrastructure code, not test definitions.
No-Weak-Crypto ✅ Passed The PR updates the extensionBinaries registry in pkg/test/extensions/binary.go. No cryptographic algorithms, crypto imports, or custom crypto implementations are present in the changed code.
Container-Privileges ✅ Passed PR modifies only Go source code (pkg/test/extensions/binary.go) that manages test binary registries, with no Kubernetes manifests or container privilege configurations present.
No-Sensitive-Data-In-Logs ✅ Passed PR removes oc-mirror from extensionBinaries registry. File has proper logging safeguards including token redaction; no sensitive data exposure in logs added or modified.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 30, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 30, 2026

Hi @redhat-chai-bot. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 30, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: redhat-chai-bot
Once this PR has been reviewed and has the lgtm label, please assign cpmeadors for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@petr-muller
Copy link
Copy Markdown
Member

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 30, 2026
@stbenjam
Copy link
Copy Markdown
Member

/override pull-ci-openshift-origin-main-e2e-agnostic-ovn-cmd
/override pull-ci-openshift-origin-main-e2e-aws-csi
/override pull-ci-openshift-origin-main-e2e-aws-disruptive
/override pull-ci-openshift-origin-main-e2e-aws-ovn
/override pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2
/override pull-ci-openshift-origin-main-e2e-aws-ovn-serial-2of2
/override pull-ci-openshift-origin-main-e2e-aws-ovn-upgrade
/override pull-ci-openshift-origin-main-e2e-azure
/override pull-ci-openshift-origin-main-e2e-azure-ovn-upgrade
/override pull-ci-openshift-origin-main-e2e-gcp-ovn
/override pull-ci-openshift-origin-main-e2e-gcp-ovn-upgrade
/override pull-ci-openshift-origin-main-e2e-metal-ipi-ovn
/override pull-ci-openshift-origin-main-e2e-vsphere-ovn
/override pull-ci-openshift-origin-main-e2e-hypershift-conformance
/override pull-ci-openshift-origin-main-e2e-aws-ovn-single-node
/override pull-ci-openshift-origin-main-e2e-aws-ovn-fips
/override pull-ci-openshift-origin-main-tls-observed-config
/override pull-ci-openshift-origin-main-tls-observed-config-hypershift
/override pull-ci-openshift-origin-main-okd-scos-e2e-aws-ovn

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 30, 2026

@stbenjam: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • pull-ci-openshift-origin-main-e2e-agnostic-ovn-cmd

Only the following failed contexts/checkruns were expected:

  • CodeRabbit
  • ci/prow/e2e-aws-csi
  • ci/prow/e2e-aws-ovn-fips
  • ci/prow/e2e-aws-ovn-microshift
  • ci/prow/e2e-aws-ovn-microshift-serial
  • ci/prow/e2e-aws-ovn-serial-1of2
  • ci/prow/e2e-aws-ovn-serial-2of2
  • ci/prow/e2e-gcp-csi
  • ci/prow/e2e-gcp-ovn
  • ci/prow/e2e-gcp-ovn-upgrade
  • ci/prow/e2e-metal-ipi-ovn-ipv6
  • ci/prow/e2e-vsphere-ovn
  • ci/prow/e2e-vsphere-ovn-upi
  • ci/prow/go-verify-deps
  • ci/prow/images
  • ci/prow/lint
  • ci/prow/okd-scos-images
  • ci/prow/unit
  • ci/prow/verify
  • ci/prow/verify-deps
  • pull-ci-openshift-origin-main-e2e-aws-csi
  • pull-ci-openshift-origin-main-e2e-aws-ovn-fips
  • pull-ci-openshift-origin-main-e2e-aws-ovn-microshift
  • pull-ci-openshift-origin-main-e2e-aws-ovn-microshift-serial
  • pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2
  • pull-ci-openshift-origin-main-e2e-aws-ovn-serial-2of2
  • pull-ci-openshift-origin-main-e2e-gcp-csi
  • pull-ci-openshift-origin-main-e2e-gcp-ovn
  • pull-ci-openshift-origin-main-e2e-gcp-ovn-upgrade
  • pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-ipv6
  • pull-ci-openshift-origin-main-e2e-vsphere-ovn
  • pull-ci-openshift-origin-main-e2e-vsphere-ovn-upi
  • pull-ci-openshift-origin-main-go-verify-deps
  • pull-ci-openshift-origin-main-images
  • pull-ci-openshift-origin-main-lint
  • pull-ci-openshift-origin-main-okd-scos-images
  • pull-ci-openshift-origin-main-unit
  • pull-ci-openshift-origin-main-verify
  • pull-ci-openshift-origin-main-verify-deps
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override pull-ci-openshift-origin-main-e2e-agnostic-ovn-cmd
/override pull-ci-openshift-origin-main-e2e-aws-csi
/override pull-ci-openshift-origin-main-e2e-aws-disruptive
/override pull-ci-openshift-origin-main-e2e-aws-ovn
/override pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2
/override pull-ci-openshift-origin-main-e2e-aws-ovn-serial-2of2
/override pull-ci-openshift-origin-main-e2e-aws-ovn-upgrade
/override pull-ci-openshift-origin-main-e2e-azure
/override pull-ci-openshift-origin-main-e2e-azure-ovn-upgrade
/override pull-ci-openshift-origin-main-e2e-gcp-ovn
/override pull-ci-openshift-origin-main-e2e-gcp-ovn-upgrade
/override pull-ci-openshift-origin-main-e2e-metal-ipi-ovn
/override pull-ci-openshift-origin-main-e2e-vsphere-ovn
/override pull-ci-openshift-origin-main-e2e-hypershift-conformance
/override pull-ci-openshift-origin-main-e2e-aws-ovn-single-node
/override pull-ci-openshift-origin-main-e2e-aws-ovn-fips
/override pull-ci-openshift-origin-main-tls-observed-config
/override pull-ci-openshift-origin-main-tls-observed-config-hypershift
/override pull-ci-openshift-origin-main-okd-scos-e2e-aws-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stbenjam
Copy link
Copy Markdown
Member

/override ci/prow/e2e-aws-csi
/override ci/prow/e2e-aws-ovn-fips
/override ci/prow/e2e-aws-ovn-microshift
/override ci/prow/e2e-aws-ovn-microshift-serial
/override ci/prow/e2e-aws-ovn-serial-1of2
/override ci/prow/e2e-aws-ovn-serial-2of2
/override ci/prow/e2e-gcp-csi
/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-gcp-ovn-upgrade
/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/e2e-vsphere-ovn
/override ci/prow/e2e-vsphere-ovn-upi

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 30, 2026

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-aws-csi, ci/prow/e2e-aws-ovn-fips, ci/prow/e2e-aws-ovn-microshift, ci/prow/e2e-aws-ovn-microshift-serial, ci/prow/e2e-aws-ovn-serial-1of2, ci/prow/e2e-aws-ovn-serial-2of2, ci/prow/e2e-gcp-csi, ci/prow/e2e-gcp-ovn, ci/prow/e2e-gcp-ovn-upgrade, ci/prow/e2e-metal-ipi-ovn-ipv6, ci/prow/e2e-vsphere-ovn, ci/prow/e2e-vsphere-ovn-upi

Details

In response to this:

/override ci/prow/e2e-aws-csi
/override ci/prow/e2e-aws-ovn-fips
/override ci/prow/e2e-aws-ovn-microshift
/override ci/prow/e2e-aws-ovn-microshift-serial
/override ci/prow/e2e-aws-ovn-serial-1of2
/override ci/prow/e2e-aws-ovn-serial-2of2
/override ci/prow/e2e-gcp-csi
/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-gcp-ovn-upgrade
/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/e2e-vsphere-ovn
/override ci/prow/e2e-vsphere-ovn-upi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stbenjam
Copy link
Copy Markdown
Member

/override ci/prow/e2e-aws-csi
/override ci/prow/e2e-aws-ovn-fips
/override ci/prow/e2e-aws-ovn-microshift
/override ci/prow/e2e-aws-ovn-microshift-serial
/override ci/prow/e2e-aws-ovn-serial-1of2
/override ci/prow/e2e-aws-ovn-serial-2of2
/override ci/prow/e2e-gcp-csi
/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-gcp-ovn-upgrade
/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/e2e-vsphere-ovn
/override ci/prow/e2e-vsphere-ovn-upi
/override ci/prow/go-verify-deps
/override ci/prow/images
/override ci/prow/okd-scos-images
/override ci/prow/unit
/override ci/prow/verify
/override ci/prow/verify-deps

This builds fine. It's a CI issue.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 30, 2026

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-aws-csi, ci/prow/e2e-aws-ovn-fips, ci/prow/e2e-aws-ovn-microshift, ci/prow/e2e-aws-ovn-microshift-serial, ci/prow/e2e-aws-ovn-serial-1of2, ci/prow/e2e-aws-ovn-serial-2of2, ci/prow/e2e-gcp-csi, ci/prow/e2e-gcp-ovn, ci/prow/e2e-gcp-ovn-upgrade, ci/prow/e2e-metal-ipi-ovn-ipv6, ci/prow/e2e-vsphere-ovn, ci/prow/e2e-vsphere-ovn-upi, ci/prow/go-verify-deps, ci/prow/images, ci/prow/okd-scos-images, ci/prow/unit, ci/prow/verify, ci/prow/verify-deps

Details

In response to this:

/override ci/prow/e2e-aws-csi
/override ci/prow/e2e-aws-ovn-fips
/override ci/prow/e2e-aws-ovn-microshift
/override ci/prow/e2e-aws-ovn-microshift-serial
/override ci/prow/e2e-aws-ovn-serial-1of2
/override ci/prow/e2e-aws-ovn-serial-2of2
/override ci/prow/e2e-gcp-csi
/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-gcp-ovn-upgrade
/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/e2e-vsphere-ovn
/override ci/prow/e2e-vsphere-ovn-upi
/override ci/prow/go-verify-deps
/override ci/prow/images
/override ci/prow/okd-scos-images
/override ci/prow/unit
/override ci/prow/verify
/override ci/prow/verify-deps

This builds fine. It's a CI issue.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stbenjam stbenjam merged commit 76ed5a8 into openshift:main May 30, 2026
20 of 21 checks passed
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 30, 2026

@redhat-chai-bot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants