TRT-2673: Filter NoExecuteTaintManager disruption from backend-disruption.json

[smg247]

The NoExecuteTaintManager serial test applies NoExecute taints to worker nodes, evicting pods without matching tolerations. This causes ~20s of expected disruption for backends like image-registry when both replicas happen to be on the tainted nodes.

#30855 added a filter to exclude this disruption from JUnit test evaluation, but the filter was not applied to the disruption serializer that writes backend-disruption.json. This file feeds disruption dashboards, so the expected disruption continued to appear there.

Move FilterOutKnownDisruptiveTestIntervals to the shared utility package and apply it in the disruption serializer's WriteContentToStorage before computing backend-disruption.json. Disruption that overlaps with NoExecuteTaintManager test windows will no longer appear in the serialized data or on dashboards.

This means disruption during known-disruptive serial tests is fully excluded from both JUnit evaluation and dashboard data. If finer-grained visibility is desired in the future (e.g. showing expected disruption in a different color on the Sippy intervals chart), that would be a separate effort to annotate rather than filter these intervals.

It is still unclear why we are only noticing this on 4.22 in GCP, but this should keep it from appearing at all...

Summary by CodeRabbit

Release Notes

• Refactor
  • Centralized disruption interval filtering to ensure consistent behavior when handling known disruptive test scenarios across monitoring components. Previously, filtering logic was duplicated in individual components.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci-robot]

@smg247: This pull request references TRT-2673 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

The NoExecuteTaintManager serial test applies NoExecute taints to worker nodes, evicting pods without matching tolerations. This causes ~20s of expected disruption for backends like image-registry when both replicas happen to be on the tainted nodes.

#30855 added a filter to exclude this disruption from JUnit test evaluation, but the filter was not applied to the disruption serializer that writes backend-disruption.json. This file feeds disruption dashboards, so the expected disruption continued to appear there.

Move FilterOutKnownDisruptiveTestIntervals to the shared utility package and apply it in the disruption serializer's WriteContentToStorage before computing backend-disruption.json. Disruption that overlaps with NoExecuteTaintManager test windows will no longer appear in the serialized data or on dashboards.

This means disruption during known-disruptive serial tests is fully excluded from both JUnit evaluation and dashboard data. If finer-grained visibility is desired in the future (e.g. showing expected disruption in a different color on the Sippy intervals chart), that would be a separate effort to annotate rather than filter these intervals.

It is still unclear why we are only noticing this on 4.22 in GCP, but this should keep it from appearing at all...

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 583edb15-b0ae-4f76-978e-57833dcb5923

📥 Commits

Reviewing files that changed from the base of the PR and between c81a4a6 and 7e8ff9d.

📒 Files selected for processing (3)

• pkg/monitortestlibrary/disruptionfilter/filter.go
• pkg/monitortestlibrary/disruptionlibrary/disruption_invariant_adapter.go
• pkg/monitortests/testframework/disruptionserializer/monitortest.go

🚧 Files skipped from review as they are similar to previous changes (1)

• pkg/monitortestlibrary/disruptionlibrary/disruption_invariant_adapter.go

---

Walkthrough

This PR extracts disruption interval filtering logic into a shared module to eliminate duplication. A new disruptionfilter package exports FilterOutKnownDisruptiveTestIntervals, which removes error events overlapping with known-disruptive E2E test intervals. Two existing consumers—the disruption invariant adapter and the test serializer—are refactored to use this shared implementation.

Changes

Disruption filter extraction and integration

Layer / File(s)	Summary
Shared disruption filter implementation pkg/monitortestlibrary/disruptionfilter/filter.go	FilterOutKnownDisruptiveTestIntervals identifies disruptive E2E test intervals matching NoExecuteTaintManager and, when found, filters the input to exclude overlapping error events. intervalsOverlap normalizes open-ended intervals (zero .To values) to a far-future timestamp, then checks overlap by .From and normalized .To values.
Adapter refactoring to use shared filter pkg/monitortestlibrary/disruptionlibrary/disruption_invariant_adapter.go	The disruption adapter adds an import for disruptionfilter, removes its local filterOutKnownDisruptiveTestIntervals helper, and updates EvaluateTestsFromConstructedIntervals to use the shared filter implementation.
Test serializer integration pkg/monitortests/testframework/disruptionserializer/monitortest.go	The test serializer adds an import for disruptionfilter and updates WriteContentToStorage to filter finalIntervals through the shared filter before computing disruption data.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: filtering NoExecuteTaintManager disruption from backend-disruption.json output.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	No Ginkgo test definitions (It/Describe/Context/When) found in any changed files. This PR modifies monitoring utility packages, not test specifications.
Test Structure And Quality	✅ Passed	The PR modifies utility code only (disruption filtering logic), not Ginkgo test code. The custom check is not applicable to this PR.
Microshift Test Compatibility	✅ Passed	This PR does not add any new Ginkgo e2e tests. It refactors filtering utilities and applies them to existing disruption monitoring code, so the MicroShift Test Compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR does not add any new Ginkgo e2e tests. Changes are limited to monitoring/disruption infrastructure code for filtering intervals; the check does not apply.
Topology-Aware Scheduling Compatibility	✅ Passed	PR modifies only monitoring/testing code (disruption data filtering), not deployment manifests or operator scheduling. No topology-sensitive scheduling constraints are introduced.
Ote Binary Stdout Contract	✅ Passed	All modified files are utility libraries with no OTE entry points (main, TestMain, BeforeSuite, etc.) and no stdout writes; changes only add filtered interval processing to disruption analysis.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR does not add any new Ginkgo e2e tests; it only modifies utility/library code for disruption filtering and monitoring, which are not subject to the IPv6/disconnected network compatibility check.
No-Weak-Crypto	✅ Passed	No weak crypto, custom implementations, or non-constant-time comparisons found. Changes focus on test disruption filtering logic only.
Container-Privileges	✅ Passed	PR contains only Go source code for monitoring/testing infrastructure, not Kubernetes manifests or container configurations. The container-privileges check is not applicable.
No-Sensitive-Data-In-Logs	✅ Passed	No logging statements in the PR expose passwords, tokens, API keys, PII, session IDs, internal hostnames, or customer data. The changes only filter disruption intervals and use benign logging.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[neisw]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neisw, smg247

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [neisw,smg247]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[smg247]

/retest-required

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[smg247]

/retest-required

[smg247]

/verified bypass

[openshift-ci-robot]

@smg247: The verified label has been added.

Details

In response to this:

/verified bypass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@smg247: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.