OCPBUGS-96581: alerting: allow KubeCPUOvercommit on compact clusters

[jan--f]

On compact 3-node clusters where control-plane nodes also serve as workers, CPU overcommit is expected during e2e test workloads. Add KubeCPUOvercommit to the allowed alert names in the [Early] firing alerts test when running on a compact cluster (no dedicated worker nodes).

Fixes https://issues.redhat.com/browse/OCPBUGS-96581

Summary by CodeRabbit

• Bug Fixes
  • Alert validation now accounts for compact cluster deployments, allowing a relevant CPU overcommit alert to be expected in those environments.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• test/extended/prometheus/OWNERS [jan--f]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@jan--f: This pull request references Jira Issue OCPBUGS-96581, which is invalid:

• expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

On compact 3-node clusters where control-plane nodes also serve as workers, CPU overcommit is expected during e2e test workloads. Add KubeCPUOvercommit to the allowed alert names in the [Early] firing alerts test when running on a compact cluster (no dedicated worker nodes).

Fixes https://issues.redhat.com/browse/OCPBUGS-96581

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: a4f295d2-79f9-4db0-be8b-d3cfb93aeff0

📥 Commits

Reviewing files that changed from the base of the PR and between f2c72ee and c68ea39.

📒 Files selected for processing (1)

• test/extended/prometheus/prometheus.go

---

Walkthrough

Added a helper function to detect compact clusters (highly-available control plane with single-replica infrastructure) and used it to extend the allowed-firing-alerts list in the platform Prometheus targets test to permit the KubeCPUOvercommit alert on such clusters.

Changes

Compact Cluster Alert Exception

Layer / File(s)	Summary
Detect compact cluster and allow alert test/extended/prometheus/prometheus.go	Adds isCompactCluster helper that reads the Infrastructure resource to check control-plane and infrastructure topology, and uses it to allow KubeCPUOvercommit in the alert-firing validation test.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Related Issues: None specified in provided information.

Suggested labels: test

Suggested reviewers: None specified.

Poem

A rabbit checks the topology's face,
Compact clusters get their special place,
One alert now allowed to fire,
CPU overcommit, no longer dire,
Hop, hop—the tests fall into grace. 🐇

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: allowing KubeCPUOvercommit on compact clusters, with the bug ID as helpful context.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The touched file’s Ginkgo titles are static strings only; the PR adds no dynamic or generated test names, just alert allowlist logic and a helper.
Test Structure And Quality	✅ Passed	The PR only adds a read-only compact-cluster helper and alert allowlist entry; no new It blocks, resources, waits, or assertion patterns are introduced, and it matches existing topology-helper style.
Microshift Test Compatibility	✅ Passed	The only added MicroShift-incompatible API usage is in an existing test tagged [apigroup:config.openshift.io], so MicroShift CI auto-skips it.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The change only allows KubeCPUOvercommit on compact clusters; it adds no multi-node/HA assumption or SNO-unsafe test behavior.
Topology-Aware Scheduling Compatibility	✅ Passed	Change only relaxes an alert test on compact clusters using ControlPlaneTopology/InfrastructureTopology; no manifests, replicas, affinity, or node selectors were added.
Ote Binary Stdout Contract	✅ Passed	No new process-level stdout writes were added; the only new code is a helper using e2e.Logf inside test logic, and no main/init/suite setup output was introduced.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR only relaxes an existing alert test; the new helper reads cluster Infrastructure topology and no IPv4-only or external connectivity patterns were added.
No-Weak-Crypto	✅ Passed	The changed Prometheus test only adds compact-cluster alert allowlisting and an Infrastructure topology check; no weak/custom crypto or secret/token comparisons appear.
Container-Privileges	✅ Passed	PR only changes a Go e2e test helper; no manifests or privileged settings (privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation) were added.
No-Sensitive-Data-In-Logs	✅ Passed	The only new log is a generic infrastructure GET error; no passwords, tokens, PII, or internal hostnames are logged.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

@jan--f: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.