fix patch of anonymous fields #4922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM |
Contributor
Author
|
got an lgtm upstream too. [merge] |
Contributor
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/3476/) (Image: devenv-fedora_2451) |
Contributor
|
[Test]ing while waiting on the merge queue |
Contributor
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/5366/) |
deads2k
force-pushed
the
fix-patch-anon
branch
from
a081d4e to
7b4cfc4
Compare
Contributor
|
Evaluated for origin test up to 7b4cfc4 |
Contributor
|
Evaluated for origin merge up to 7b4cfc4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocker bug: https://bugzilla.redhat.com/show_bug.cgi?id=1267474 .
@mfojtik this the upstream version of the kube code.
@liggitt this is worth some thinking on. Reasoning about safety and intent isn't trivial.