Block build cloning when BC is paused#6765
Merged
openshift-bot merged 1 commit intoopenshift:masterfrom Jan 22, 2016
Merged
Conversation
Contributor
|
lgtm [merge] |
Contributor
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/4704/) (Image: devenv-rhel7_3208) |
Contributor
|
Evaluated for origin merge up to b19048d |
Contributor
|
[Test]ing while waiting on the merge queue |
Contributor
|
Evaluated for origin test up to b19048d |
Contributor
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/264/) |
openshift-bot
pushed a commit
that referenced
this pull request
Jan 22, 2016
Merged by openshift-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #6185 we introduced a new annotation for pausing BCs as they are being deleted. We disable BC instantiation while this annotation is present. This PR disables it for build cloning as well.
@jhadvig found this one
@bparees might be interested in this one