Merged
Conversation
pkg/diagnostics/pod/dns.go
Outdated
| msg := new(dns.Msg) | ||
| msg.SetQuestion("wildcard."+randomString+"."+domain+".", dns.TypeA) | ||
| msg.RecursionDesired = true // otherwise we just get the authority section for the TLD | ||
| seenDP2014 := map[string]bool{} |
Contributor
|
minor comments, then lgtm. |
sosiouxme
force-pushed
the
20160215-bz1302649-diag-panic
branch
from
3cdcf84 to
a796117
Compare
deduplicated warnings, reduced if/else logic
sosiouxme
force-pushed
the
20160215-bz1302649-diag-panic
branch
from
a796117 to
d6580b1
Compare
Member
Author
|
@deads2k addressed your comments and found some more code to pick at while testing. Hopefully it is less eye-stabby; feel free to review again. |
Member
Author
|
[Merge] |
Contributor
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/5075/) (Image: devenv-rhel7_3515) |
Contributor
|
Evaluated for origin merge up to d6580b1 |
Contributor
|
[Test]ing while waiting on the merge queue |
Contributor
|
Evaluated for origin test up to d6580b1 |
Contributor
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/1503/) |
openshift-bot
pushed a commit
that referenced
this pull request
Feb 23, 2016
Merged by openshift-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug 1302649