Skip to content

Appgen and New-App commands #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 4, 2015
Merged

Appgen and New-App commands #794

merged 4 commits into from
Feb 4, 2015

Conversation

csrwng
Copy link
Contributor

@csrwng csrwng commented Jan 29, 2015

App config generation commands

@csrwng
Copy link
Contributor Author

csrwng commented Jan 29, 2015

@smarterclayton - common config gen code

@csrwng csrwng mentioned this pull request Jan 29, 2015
Closed
@csrwng csrwng force-pushed the experimental_appgen branch 2 times, most recently from 01f3067 to 9f0c205 Compare January 29, 2015 20:59
mfojtik
mfojtik reviewed Jan 30, 2015
View reviewed changes
pkg/cmd/experimental/appgen/app-gen.go Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would use switch here :)

@csrwng csrwng force-pushed the experimental_appgen branch 2 times, most recently from 3b56b38 to aad2b85 Compare February 1, 2015 16:33
@smarterclayton
Copy link
Contributor

When #825 lands openshift ex app-gen will be visible to users.

@csrwng csrwng force-pushed the experimental_appgen branch 2 times, most recently from dee5090 to 18c7f1e Compare February 2, 2015 19:00
@csrwng
Copy link
Contributor Author

csrwng commented Feb 2, 2015

@bparees, @smarterclayton - I added a doc describing app-gen, PTAL

bparees
bparees reviewed Feb 2, 2015
View reviewed changes
docs/app-gen.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be " openshift-experimental app-gen [source]" ?

@bparees
Copy link
Contributor

bparees commented Feb 2, 2015

@csrwng reviewed the doc only, it looks good aside from my minor comments.

@csrwng csrwng force-pushed the experimental_appgen branch 3 times, most recently from 1fb078f to cbfb5f1 Compare February 3, 2015 14:06
@bparees
Copy link
Contributor

bparees commented Feb 3, 2015

@danmcp @smarterclayton what are your opinions on trying to get this in for beta1, given it will be under the experimental cli options?

@csrwng csrwng force-pushed the experimental_appgen branch from cbfb5f1 to 17c7e08 Compare February 3, 2015 16:06
@smarterclayton
Copy link
Contributor

It's gonna go in - I've gotta get new-app working today or tomorrow.

----- Original Message -----

@danmcp @smarterclayton what are your opinions on trying to get this in for
beta1, given it will be under the experimental cli options?

Reply to this email directly or view it on GitHub:
#794 (comment)

@smarterclayton
Copy link
Contributor

Yes

----- Original Message -----

@smarterclayton so this PR will cover both the experimental "appgen" tooling
(cesar's) and your new-app tooling?

Reply to this email directly or view it on GitHub:
#794 (comment)

@csrwng csrwng force-pushed the experimental_appgen branch from 17c7e08 to 6982a3d Compare February 3, 2015 19:42
@csrwng
Copy link
Contributor Author

csrwng commented Feb 3, 2015

@smarterclayton - I've pushed my latest code. Should be ready.

@csrwng csrwng force-pushed the experimental_appgen branch 2 times, most recently from d5be88e to fd4023d Compare February 4, 2015 14:08
0xmichalis
0xmichalis reviewed Feb 4, 2015
View reviewed changes
docs/app-gen.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the markdown here to follow the Github markdown rules eg. when you want to create quoted text which contains code, leave its previous (before first command) and next (after last command) lines empty (so there should be an empty line between Examples: and $ openshift ex generate). Also use 4 spaces instead of 2 for indentation. See this fix on Kubernetes for kubectl.md.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Thx

@csrwng csrwng force-pushed the experimental_appgen branch from fd4023d to b757009 Compare February 4, 2015 14:38
@smarterclayton smarterclayton modified the milestone: 0.3.0 (beta1) Feb 4, 2015
@csrwng csrwng force-pushed the experimental_appgen branch from b757009 to f3897c7 Compare February 4, 2015 16:58
@csrwng csrwng changed the title [WIP] Appgen and New-App commands Appgen and New-App commands Feb 4, 2015
@csrwng csrwng force-pushed the experimental_appgen branch from f3897c7 to 0935f47 Compare February 4, 2015 18:26
@smarterclayton
Copy link
Contributor

LGTM [merge], will iterate more on this once it's in

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/817/) (Image: devenv-fedora_701)

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/976/)

@csrwng csrwng force-pushed the experimental_appgen branch from 0935f47 to c4cbbc7 Compare February 4, 2015 19:08
@openshift-bot
Copy link
Contributor

Evaluated for origin up to c4cbbc7

openshift-bot pushed a commit that referenced this pull request Feb 4, 2015
Merge pull request #794 from csrwng/experimental_appgen
a0f14ff 
Merged by openshift-bot
@openshift-bot openshift-bot merged commit a0f14ff into openshift:master Feb 4, 2015
@csrwng csrwng deleted the experimental_appgen branch February 5, 2015 13:17
@0xmichalis 0xmichalis mentioned this pull request Feb 5, 2015
Closed
@coveralls
Copy link

coveralls commented Aug 31, 2016 •
edited
Loading

Coverage Status

Changes Unknown when pulling c4cbbc7 on csrwng:experimental_appgen into * on openshift:master*.

jpeeler pushed a commit to jpeeler/origin that referenced this pull request Feb 1, 2018
Merge pull request openshift#794 from krancour/produce-latest
141403b 
on release, also push images tagged as 'latest'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.3.0 (beta1)

Development

Successfully merging this pull request may close these issues.

7 participants

@csrwng @smarterclayton @bparees @openshift-bot @coveralls @mfojtik @0xmichalis