Skip to content

WIP Improve new-build output cycle detection#7984

Closed
rhcarvalho wants to merge 1 commit intoopenshift:masterfrom
rhcarvalho:issue7718-build-output-cycle-detection-followup
Closed

WIP Improve new-build output cycle detection#7984
rhcarvalho wants to merge 1 commit intoopenshift:masterfrom
rhcarvalho:issue7718-build-output-cycle-detection-followup

Conversation

@rhcarvalho
Copy link
Copy Markdown
Contributor

This is a follow up to #7936.

The idea is to test all combinations of build strategy/from, triggers
and output reference, and improve the implementation to behave correctly
in all cases.

@bparees FYI.

@rhcarvalho
Copy link
Copy Markdown
Contributor Author

Cover:

  • The input and output images are not the same (from Regression: new-build / new-app input output cycle detection #7718)

            "sourceStrategy": {
              "from": {
                "kind": "DockerImage",
                "name": "centos/ruby-22-centos7:latest"
              }
            }
          "output": {
            "to": {
              "kind": "ImageStreamTag",
              "name": "internal-image:latest"
            }
          },
  • Print a warning if we can detect a build loop in oc new-app

@bparees
Copy link
Copy Markdown
Contributor

bparees commented Mar 14, 2016

1 commit, zero files changed. impressive :)

@rhcarvalho
Copy link
Copy Markdown
Contributor Author

Yes! Can you find any bug? ;-)
On Mar 14, 2016 8:30 PM, "Ben Parees" notifications@github.com wrote:

1 commit, zero files changed. impressive :)


Reply to this email directly or view it on GitHub
#7984 (comment).

@bparees
Copy link
Copy Markdown
Contributor

bparees commented Mar 14, 2016

Yes! Can you find any bug? ;-)

touche :)

WIP Improve new-build output cycle detection

This is a follow up to openshift#7936.

The idea is to test all combinations of build
strategy/from, triggers and output reference, and
improve the implementation to behave correctly in all
cases.
@rhcarvalho rhcarvalho force-pushed the issue7718-build-output-cycle-detection-followup branch from 5d46676 to dac01fe Compare May 16, 2016 14:40
@danmcp
Copy link
Copy Markdown

danmcp commented Jun 14, 2016

@rhcarvalho @bparees Bump

@openshift-bot
Copy link
Copy Markdown
Contributor

Origin Action Required: Pull request cannot be automatically merged, please rebase your branch from latest HEAD and push again

@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 12, 2016
@rhcarvalho
Copy link
Copy Markdown
Contributor Author

Superseded by #10067.

@rhcarvalho rhcarvalho closed this Aug 12, 2016
@rhcarvalho rhcarvalho deleted the issue7718-build-output-cycle-detection-followup branch August 12, 2016 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants