Add reconcile protection for roles#8774
Merged
openshift-bot merged 2 commits intoopenshift:masterfrom May 7, 2016
liggitt:exclude-reconcile
Merged
Add reconcile protection for roles#8774openshift-bot merged 2 commits intoopenshift:masterfrom liggitt:exclude-reconcile
openshift-bot merged 2 commits intoopenshift:masterfrom
liggitt:exclude-reconcile
Conversation
Contributor
Author
Contributor
Author
|
[test] |
| "~" | ||
| ] | ||
| }, | ||
| { |
Contributor
There was a problem hiding this comment.
nothing else used this file?
Contributor
Author
There was a problem hiding this comment.
split into a separate file for this test
Contributor
|
lgtm |
If we are in additive mode, and the actual role has extra permissions and no missing permissions, don't report it needing to be reconciled
Contributor
Author
|
[merge] |
Contributor
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/5842/) (Image: devenv-rhel7_4132) |
Contributor
|
Evaluated for origin test up to 09032eb |
Contributor
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/3652/) |
Contributor
|
Evaluated for origin merge up to 09032eb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows customizing default roles and protecting them from reconciliation. This will let us safely customize admin/edit/view roles in environments like online
Proposed annotation name is
openshift.io/reconcile-protectto align with proposedkubernetes.io/write-protectannotation upstream