oc describe for JenkinsBuildStrategy#9446
Conversation
yes that's correct because you can just supply a Jenkinsfile in the root of your git repo. |
pkg/cmd/cli/describe/describer.go
Outdated
| formatString(out, "Jenkinsfile path", s.JenkinsfilePath) | ||
| } | ||
| if len(s.Jenkinsfile) != 0 { | ||
| formatString(out, "Jenkinsfile contents", s.Jenkinsfile) |
There was a problem hiding this comment.
we may not want to print the full contents... do we print the full Dockerfile when the buildconfig has an in-line dockerfile definition?
There was a problem hiding this comment.
it appears to print the full contents, though it does some newline related processing:
fmt.Fprintf(out, "Dockerfile:\n")
for _, s := range strings.Split(*p.Source.Dockerfile, "\n") {
fmt.Fprintf(out, " %s\n", s)
}
I'll mimic this for the Jenkinsfile.
|
comment induced updated pushed |
|
lgtm, thanks @gabemontero! |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin test up to 7a644e8 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/5143/) |
|
merge job got yum/mirror issues during conformance and integration tests |
|
[merge] |
2 similar comments
|
[merge] |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/5143/) (Image: devenv-rhel7_4424) |
|
[merge] On Tue, Jun 21, 2016 at 5:55 PM, OpenShift Bot notifications@github.com
Ben Parees | OpenShift |
|
Evaluated for origin merge up to 7a644e8 |
3 participants
Fixes #9441
@bparees PTAL
btw, my reading of the types.go is that both Jenkinsfile and JenkinsfilePath can be empty, and I don't see any validation insuring at least one of them is set. Is that intended?