overlay: stop disabling iscsid.socket

[jlebon]

The iSCSI daemon is now socket-activated so that it's only running when
needed rather than always enabled. We're breaking that by disabling
iscsid.socket.

This effectively reverts 929ac48 ("c9s: Disable iscsid.socket"). It's
not certain why this was done, but it was likely to workaround failing
tests. These tests should be fixed now[1] so we should be able to stop
doing this.

[jlebon]

Requires: #1294

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[jlebon]

And now rebased!

[travier]

/lgtm
/retest

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlebon, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jlebon,travier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@jlebon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[mkowalski]

/cherry-pick release-4.13

[openshift-cherrypick-robot]

@mkowalski: #1298 failed to apply on top of branch "release-4.13":

Applying: overlay: stop disabling `iscsid.socket`
Using index info to reconstruct a base tree...
M	overlay.d/07el9/usr/lib/systemd/system-preset/36-iscsid-disabled.preset
Falling back to patching base and 3-way merge...
Auto-merging overlay.d/07el9/usr/lib/systemd/system-preset/36-iscsid-disabled.preset
CONFLICT (content): Merge conflict in overlay.d/07el9/usr/lib/systemd/system-preset/36-iscsid-disabled.preset
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 overlay: stop disabling `iscsid.socket`
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.