Skip to content

Add unassign account#123

Merged
openshift-ci[bot] merged 2 commits intoopenshift:masterfrom
katherinelc321:unassignAccount
Aug 17, 2021
Merged

Add unassign account#123
openshift-ci[bot] merged 2 commits intoopenshift:masterfrom
katherinelc321:unassignAccount

Conversation

@katherinelc321
Copy link
Contributor

@katherinelc321 katherinelc321 commented Jul 13, 2021

This cmd takes either an username or account ID and removes its IAM roles, policies, groups, untags it and moves it back to the root Ou. OSD-7361

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 13, 2021
@openshift-ci openshift-ci bot requested review from ArielLima and rogbas July 13, 2021 17:48
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 13, 2021
@katherinelc321 katherinelc321 force-pushed the unassignAccount branch 2 times, most recently from 7c60283 to 06f58bd Compare July 20, 2021 01:03
@drpaneas drpaneas self-assigned this Jul 20, 2021
Copy link
Contributor

@drpaneas drpaneas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Katherine! I have dropped you some comments related to testing, feel free to ping me in Slack if you have any questions about them.

Copy link
Contributor

@iamkirkbater iamkirkbater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're very much on the right track here. A few small usability changes, as well as the parsing of the response that could use some work.

Can you also explain to those who might come after me to review this in the next two weeks how they would go about testing this using a real account or something?

Keep up the great work!

@iamkirkbater
Copy link
Contributor

To those coming after me to review, if the changes that I've asked for get merged, then this should be all set to go, provided it can be tested.

Also worthy to note, not having this merged should not effect the ability to demo this. You should still be able to demo off of this branch.

Copy link
Contributor

@iamkirkbater iamkirkbater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamkirkbater, katherinelc321

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2021
@openshift-ci openshift-ci bot merged commit e5b4ae5 into openshift:master Aug 17, 2021
@katherinelc321 katherinelc321 deleted the unassignAccount branch August 24, 2021 16:08
devppratik pushed a commit to devppratik/osdctl that referenced this pull request Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants