Add unassign account#123
Conversation
a7fe8f2 to
b7a51b7
Compare
7c60283 to
06f58bd
Compare
drpaneas
left a comment
There was a problem hiding this comment.
Great work Katherine! I have dropped you some comments related to testing, feel free to ping me in Slack if you have any questions about them.
iamkirkbater
left a comment
There was a problem hiding this comment.
You're very much on the right track here. A few small usability changes, as well as the parsing of the response that could use some work.
Can you also explain to those who might come after me to review this in the next two weeks how they would go about testing this using a real account or something?
Keep up the great work!
|
To those coming after me to review, if the changes that I've asked for get merged, then this should be all set to go, provided it can be tested. Also worthy to note, not having this merged should not effect the ability to demo this. You should still be able to demo off of this branch. |
04af496 to
4e5381a
Compare
5b217c7 to
36d5c75
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamkirkbater, katherinelc321 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add unassign account
This cmd takes either an username or account ID and removes its IAM roles, policies, groups, untags it and moves it back to the root Ou. OSD-7361