Skip to content

OSD-19982: osdctl improve limited support workflow#534

Merged
openshift-merge-bot[bot] merged 11 commits intoopenshift:masterfrom
vibhuti-chalise:lttemplate
Apr 25, 2024
Merged

OSD-19982: osdctl improve limited support workflow#534
openshift-merge-bot[bot] merged 11 commits intoopenshift:masterfrom
vibhuti-chalise:lttemplate

Conversation

@vibhuti-chalise
Copy link
Contributor

@vibhuti-chalise vibhuti-chalise commented Mar 14, 2024

corresponds to Jira issue https://issues.redhat.com/browse/OSD-19982
Summary of the changes are as below:

  1. The current LS workflow requires 3 flags (problem, resolution & misconfiguration) to be compulsory. The flag evidence is option. Based on the description for OSD-19882, this PR extends to use templates like ScheduledChaosTest or DR Test to be directly used without all problem, resolution, misconfiguration & evidence flag.
  2. Based on AC for OSD-19470, we will also add a template that SRE can use in general to add the LS (Templates can be added separately)
  3. This does not remove the current way the command works. It is still valid and we will look for suggestions from SRE what to keep/change.
  4. User cannot use problem, resolution, evidence & misconfiguration flags when using the --template flag.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 14, 2024
@openshift-ci openshift-ci bot requested review from dustman9000 and typeid March 14, 2024 07:49
@devppratik
Copy link
Contributor

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2024
@devppratik
Copy link
Contributor

devppratik commented Mar 14, 2024

/retitle OSD-19982: osdctl improve limited support workflow

@openshift-ci openshift-ci bot changed the title PR for Jira task OSD-19982 OSD-19982: osdctl improve limited support workflow Mar 14, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 14, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 14, 2024

@vibhuti-chalise: This pull request references OSD-19982 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

Details

In response to this:

https://issues.redhat.com/browse/OSD-19982

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 21, 2024
@devppratik
Copy link
Contributor

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2024
@Tafhim
Copy link
Contributor

Tafhim commented Apr 16, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2024
@AlexVulaj
Copy link
Contributor

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 18, 2024
@devppratik
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 23, 2024

@vibhuti-chalise: This pull request references OSD-19982 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

Details

In response to this:

corresponds to Jira issue https://issues.redhat.com/browse/OSD-19982
Summary of the changes are as below:

  1. The current LS workflow requires 3 flags (problem, resolution & misconfiguration) to be compulsory. The flag evidence is option. Based on the description for OSD-19882, this PR extends to use templates like ScheduledChaosTest or DR Test to be directly used without all problem, resolution, misconfiguration & evidence flag.
  2. Based on AC for OSD-19470, we will also add a template that SRE can use in general to add the LS (Templates can be added separately)
  3. This does not remove the current way the command works. It is still valid and we will look for suggestions from SRE what to keep/change.
  4. User cannot use problem, resolution, evidence & misconfiguration flags when using the --template flag.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 23, 2024

@vibhuti-chalise: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@fahlmant fahlmant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2024
@devppratik
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: devppratik, fahlmant, Tafhim, vibhuti-chalise

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit fb93006 into openshift:master Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants