Skip to content

[SDE-3246] Cloudtail write-events feature#560

Merged
openshift-merge-bot[bot] merged 9 commits intoopenshift:masterfrom
TomNelsonTembo:write-events-feature
May 8, 2024
Merged

[SDE-3246] Cloudtail write-events feature#560
openshift-merge-bot[bot] merged 9 commits intoopenshift:masterfrom
TomNelsonTembo:write-events-feature

Conversation

@TomNelsonTembo
Copy link
Contributor

This pull request introduces a new command, osdctl cloudtrail write-events, enhancing the capabilities of osdctl to effectively query CloudTrail logs for write events related to a specific cluster.

@openshift-ci openshift-ci bot requested review from iamkirkbater and typeid May 5, 2024 21:44
@TomNelsonTembo TomNelsonTembo changed the title Cloudtail write-events feature [SDE-3246] Cloudtail write-events feature May 6, 2024
@typeid
Copy link
Member

typeid commented May 8, 2024

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label May 8, 2024
Co-authored-by: typeid <github@typeid.org>
Copy link
Member

@typeid typeid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Great work @TomNelsonTembo!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TomNelsonTembo, typeid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 8, 2024

@TomNelsonTembo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 778e2c5 into openshift:master May 8, 2024
TomNelsonTembo added a commit to TomNelsonTembo/osdctl that referenced this pull request May 27, 2024
* added write-events cmd

* fixes printEvents function bug

* go.mod tidy

* fixes filterEvents Function bug

* update printEvents function

* modifies reverse slice for printEvents function

* updates to write-events_test

* fixes nil ptr dereference bug

* Update cmd/cloudtrail/write-events.go

Co-authored-by: typeid <github@typeid.org>

---------

Co-authored-by: typeid <github@typeid.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants