Skip to content

Remove completion command#571

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
AlexVulaj:clean-up-completion
May 21, 2024
Merged

Remove completion command#571
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
AlexVulaj:clean-up-completion

Conversation

@AlexVulaj
Copy link
Contributor

Per Cobra's documentation, this functionality is automatically provided and we don't need our own custom command for it:

Cobra will automatically provide your program with a fully functional completion command, similarly to how it provides the help command.

@openshift-ci openshift-ci bot requested review from iamkirkbater and mjlshen May 21, 2024 15:57
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2024
Copy link
Contributor

@mjlshen mjlshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexVulaj, mjlshen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 21, 2024

@AlexVulaj: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 673966e into openshift:master May 21, 2024
@AlexVulaj AlexVulaj deleted the clean-up-completion branch May 21, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants