Allow reading creds as env var for account mgmt commands #604
Conversation
openshift-ci
bot
added
the
approved
|
/hold for testing MR was created to add permission: https://gitlab.cee.redhat.com/service/app-interface/-/merge_requests/114730 |
openshift-ci
bot
added
the
do-not-merge/hold
iamkirkbater
left a comment
iamkirkbater
left a comment
There was a problem hiding this comment.
Can I ask why we're going with osd-staging-1 and osd-staging-2-prod? Can we standardize on just being osd-staging-#? I specifically worry about osd-staging-2-prod because staging-2 is not prod and should not be used for any prod things.
Additionally can we pull osd-staging-1 and osd-staging-2 out into constants somewhere within osdctl that makes sense and reference them from that?
|
/label tide/merge-method-squash |
openshift-ci
bot
added
the
tide/merge-method-squash
sam-nguyen7
force-pushed
the
aws-sso-support
branch
from
91d2edd to
c83c131
Compare
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
iamkirkbater
left a comment
iamkirkbater
left a comment
There was a problem hiding this comment.
Two small changes, one just a small nit about the usage of constants and the other just a better name for a var.
Thanks!
|
@sam-nguyen7: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm Thanks for making the changes! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamkirkbater, sam-nguyen7 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
https://issues.redhat.com/browse/OSD-20603
Update osdctl account mgmt commands to use RH SSO credentials generated via https://github.com/app-sre/rh-aws-saml-login which spawns a new shell with the AWS_ACCOUNT_NAME environment variable.