Add network packet-capture#77
Merged
openshift-merge-robot merged 7 commits intoopenshift:masterfrom Dec 14, 2020
Merged
Conversation
9f74b94 to
b832843
Compare
Member
Author
|
/assign @rogbas |
b832843 to
1feafea
Compare
1feafea to
441f8c6
Compare
441f8c6 to
0b8abac
Compare
Contributor
iamkirkbater
left a comment
There was a problem hiding this comment.
Overall the code looks good, I still have to build/test locally. Just a few small things we can discuss but nothing that should block this getting in.
Member
Author
|
/label tide/merge-method-squash |
rogbas
reviewed
Dec 14, 2020
|
Overall the change is looking good, I just added a question that not necessarily blocks merging this PR. |
rogbas
requested changes
Dec 14, 2020
rogbas
reviewed
Dec 14, 2020
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dustman9000, rogbas The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
devppratik
pushed a commit
to devppratik/osdctl
that referenced
this pull request
Aug 23, 2023
* Add network packet-capture to perform a priviledged node tcpdump. * Use timestamp in pcap filename and add 'pcap' alias * Throw error when DS with the same name exists * Change default packet capture DS name * Change image name to openshift-sre org * Change test function name * Make docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new domain (
network) and action: (packet-capture) which runs a privileged tcpdump on nodes for a given duration (60s). After completion, will copy the .pcap files to the local directory (./capture-output/).Options:
Example run: