Skip to content

Bug 2087934: Remove go get#192

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
josephdrichard:remove_go_get
May 18, 2022
Merged

Bug 2087934: Remove go get#192
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
josephdrichard:remove_go_get

Conversation

@josephdrichard
Copy link
Copy Markdown
Contributor

@josephdrichard josephdrichard commented May 18, 2022

Deprecated in 1.17 and removed in 1.18.
See https://go.dev/doc/go-get-install-deprecation

@openshift-ci openshift-ci bot requested review from aneeshkp and dcbw May 18, 2022 03:48
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2022
@josephdrichard
Copy link
Copy Markdown
Contributor Author

josephdrichard commented May 18, 2022

/hold
PRs #184 and #185 are blocked from merging because of ci failure from upgrading go version. Testing with this fix and cherry-pick of #184. If tests pass, then I will remove fix for #184 and then this can be merged, and then #184 and #185 can be merged afterwards.
@aneeshkp

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 18, 2022
@aneeshkp
Copy link
Copy Markdown
Contributor

aneeshkp commented May 18, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2022
@josephdrichard josephdrichard changed the title Remove go get Bug 2087934: Remove go get May 18, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 18, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented May 18, 2022

@josephdrichard: This pull request references Bugzilla bug 2087934, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (obochan@redhat.com), skipping review request.

Details

In response to this:

Bug 2087934: Remove go get

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@josephdrichard
Replace go get with go install
77275bd 
Go get was deprecated for installing packages in go 1.17 and removed in
go 1.18.  Replace with using go install.
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 18, 2022
@josephdrichard
Copy link
Copy Markdown
Contributor Author

josephdrichard commented May 18, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 18, 2022
@josephdrichard
Copy link
Copy Markdown
Contributor Author

josephdrichard commented May 18, 2022

/retest

@aneeshkp
Copy link
Copy Markdown
Contributor

aneeshkp commented May 18, 2022

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented May 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aneeshkp, josephdrichard, sebrandon1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [aneeshkp,josephdrichard]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented May 18, 2022

@josephdrichard: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 2390cfe into openshift:master May 18, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented May 18, 2022

@josephdrichard: All pull requests linked via external trackers have merged:

Bugzilla bug 2087934 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2087934: Remove go get

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jzding pushed a commit to jzding/ptp-operator that referenced this pull request Mar 21, 2026
@openshift-merge-robot
Merge pull request openshift#192 from vitus133/fix-mutex
526d380 
Fix mutex lock when locked
jzding pushed a commit to jzding/ptp-operator that referenced this pull request Mar 24, 2026
@edcdavid
Merge pull request openshift#192 from yaronh12/add-mustgather-to-ci
da35c41 
Add must-gather collection to CI pipeline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcbw dcbw Awaiting requested review from dcbw

2 more reviewers

@sebrandon1 sebrandon1 sebrandon1 approved these changes

@aneeshkp aneeshkp aneeshkp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@aneeshkp aneeshkp

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@josephdrichard @aneeshkp @sebrandon1 @openshift-merge-robot