Skip to content

Implement PTP reboot-recovery test#194

Closed
bnshr wants to merge 1 commit intoopenshift:masterfrom
bnshr:CNF-4794
Closed

Implement PTP reboot-recovery test#194
bnshr wants to merge 1 commit intoopenshift:masterfrom
bnshr:CNF-4794

Conversation

@bnshr
Copy link
Copy Markdown
Contributor

@bnshr bnshr commented Jun 1, 2022 •
edited
Loading

This PR includes an automated test that makes sure PTP recovers within a reasonable timeframe after reboot.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 1, 2022
@openshift-ci openshift-ci bot requested review from aneeshkp and s1061123 June 1, 2022 12:02
@openshift-ci openshift-ci bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 1, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jun 1, 2022

Hi @bnshr. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bnshr bnshr changed the title Implement PTP reboot-recovery test CNF-4794 : Implement PTP reboot-recovery test Jun 1, 2022
edcdavid
edcdavid reviewed Jun 1, 2022
View reviewed changes
edcdavid
edcdavid reviewed Jun 1, 2022
View reviewed changes
edcdavid
edcdavid reviewed Jun 1, 2022
View reviewed changes
@aneeshkp
Copy link
Copy Markdown
Contributor

aneeshkp commented Jun 7, 2022

@bnshr any updates

@bnshr
Copy link
Copy Markdown
Contributor Author

bnshr commented Jun 13, 2022

@aneeshkp Could you please review this PR?

@bnshr bnshr mentioned this pull request Jun 13, 2022
Merged
@josephdrichard
Copy link
Copy Markdown
Contributor

josephdrichard commented Jun 16, 2022

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 16, 2022
edcdavid
edcdavid reviewed Jun 17, 2022
View reviewed changes
edcdavid
edcdavid reviewed Jun 17, 2022
View reviewed changes
edcdavid
edcdavid reviewed Jun 17, 2022
View reviewed changes
edcdavid
edcdavid reviewed Jun 17, 2022
View reviewed changes
@bnshr bnshr changed the title CNF-4794 : Implement PTP reboot-recovery test Implement PTP reboot-recovery test Jun 20, 2022
aneeshkp
aneeshkp reviewed Jun 21, 2022
View reviewed changes
test/conformance/ptp/ptp.go
Expect(err).NotTo(HaveOccurred())
Expect(len(ptpPods.Items)).To(BeNumerically(">", 0), "linuxptp-daemon is not deployed on cluster")

ptpSlaveRunningPods := []v1core.Pod{}
Copy link
Copy Markdown
Contributor

@aneeshkp aneeshkp Jun 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you already have this pod configured? Why would you want to rediscover this artifacts ?

@aneeshkp
Copy link
Copy Markdown
Contributor

aneeshkp commented Jun 21, 2022

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 21, 2022
@openshift-ci openshift-ci bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 30, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jul 7, 2022

@bnshr: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bnshr bnshr closed this Jul 7, 2022
@bnshr bnshr reopened this Jul 7, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jul 7, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bnshr
To complete the pull request process, please assign aneeshkp after the PR has been reviewed.
You can assign the PR to them by writing /assign @aneeshkp in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jul 7, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bnshr
To complete the pull request process, please assign aneeshkp after the PR has been reviewed.
You can assign the PR to them by writing /assign @aneeshkp in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jul 7, 2022

@bnshr: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/operator-e2e 6f0c91c link true /test operator-e2e
ci/prow/e2e-aws 6f0c91c link true /test e2e-aws
ci/prow/gofmt 6f0c91c link true /test gofmt
ci/prow/ci-index 6f0c91c link true /test ci-index
ci/prow/images 6f0c91c link true /test images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bnshr bnshr closed this Jul 7, 2022
nocturnalastro pushed a commit to nocturnalastro/ptp-operator that referenced this pull request Mar 13, 2026
@josephdrichard
Merge pull request openshift#194 from jzding/tls-profile
a13bcee 
Set tls-profiles feature annotation to true in CSV
jzding pushed a commit to jzding/ptp-operator that referenced this pull request Mar 21, 2026
@openshift-merge-robot
Merge pull request openshift#194 from aneeshkp/gm-bugs
f378891 
fix gpsd running again after exit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@s1061123 s1061123 Awaiting requested review from s1061123

2 more reviewers

@aneeshkp aneeshkp aneeshkp left review comments

@edcdavid edcdavid edcdavid left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bnshr @aneeshkp @josephdrichard @edcdavid