Skip to content

Boundary clock testing with rapid host based L2 discovery#197

Merged
openshift-ci[bot] merged 3 commits intoopenshift:masterfrom
edcdavid:bc-support-2
Jul 13, 2022
Merged

Boundary clock testing with rapid host based L2 discovery#197
openshift-ci[bot] merged 3 commits intoopenshift:masterfrom
edcdavid:bc-support-2

Conversation

@edcdavid
Copy link
Copy Markdown
Contributor

@edcdavid edcdavid commented Jun 13, 2022 •
edited
Loading

This is a work in progress PR adding BC testing functionality. Please check updated conformance test documentation within this PR for details (https://github.com/openshift/ptp-operator/blob/8acd8c7e5c274ccd9986f47031e0d67cae49d4f6/test/README.md ).
The L2 discovery feature is implemented in the following project:
https://github.com/test-network-function/l2discovery

@openshift-ci openshift-ci bot requested review from SchSeba and pliurh June 13, 2022 15:43
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 13, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jun 13, 2022

Hi @edcdavid. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@edcdavid edcdavid changed the title Boundary clock testing and rapid host based L2 discovery Boundary clock testing with rapid host based L2 discovery Jun 15, 2022
edcdavid added a commit to edcdavid/ptp-operator that referenced this pull request Jun 15, 2022
@edcdavid
Boundary clock testing with rapid host based L2 discovery openshift#197
a0006ed
edcdavid added a commit to edcdavid/ptp-operator that referenced this pull request Jun 15, 2022
@edcdavid
Boundary clock testing with rapid host based L2 discovery openshift#197
5e03300
@josephdrichard
Copy link
Copy Markdown
Contributor

josephdrichard commented Jun 16, 2022

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 16, 2022
josephdrichard
josephdrichard suggested changes Jun 16, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@josephdrichard josephdrichard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you split this PR into three separate commits (still one PR)? One with just doc and image changes, one with the vendor changes, and one with the code changes.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 16, 2022
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 16, 2022
@edcdavid edcdavid force-pushed the bc-support-2 branch 3 times, most recently from 21e803e to 1bf9bad Compare June 17, 2022 21:33
aneeshkp
aneeshkp reviewed Jun 21, 2022
View reviewed changes
aneeshkp
aneeshkp reviewed Jun 21, 2022
View reviewed changes
aneeshkp
aneeshkp reviewed Jun 21, 2022
View reviewed changes
aneeshkp
aneeshkp reviewed Jun 21, 2022
View reviewed changes
aneeshkp
aneeshkp reviewed Jun 21, 2022
View reviewed changes
aneeshkp
aneeshkp reviewed Jun 21, 2022
View reviewed changes
aneeshkp
aneeshkp reviewed Jun 21, 2022
View reviewed changes
aneeshkp
aneeshkp reviewed Jun 21, 2022
View reviewed changes
aneeshkp
aneeshkp reviewed Jun 21, 2022
View reviewed changes
aneeshkp
aneeshkp reviewed Jun 21, 2022
View reviewed changes
aneeshkp
aneeshkp reviewed Jun 21, 2022
View reviewed changes
@edcdavid edcdavid force-pushed the bc-support-2 branch 2 times, most recently from 9a52ce5 to f1d11b8 Compare June 23, 2022 19:03
josephdrichard
josephdrichard approved these changes Jun 23, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@josephdrichard josephdrichard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2022
@aneeshkp
Copy link
Copy Markdown
Contributor

aneeshkp commented Jun 24, 2022

/test operator-e2e

@aneeshkp
Copy link
Copy Markdown
Contributor

aneeshkp commented Jun 24, 2022

/retest

1 similar comment
@aneeshkp
Copy link
Copy Markdown
Contributor

aneeshkp commented Jun 24, 2022

/retest

@openshift-ci openshift-ci bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm Indicates that a PR is ready to be merged. labels Jul 11, 2022
@aneeshkp
Copy link
Copy Markdown
Contributor

aneeshkp commented Jul 11, 2022

/retest

@aneeshkp
Copy link
Copy Markdown
Contributor

aneeshkp commented Jul 11, 2022

@edcdavid need to rebase and resolve merge conflicts

@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 11, 2022
@aneeshkp
Copy link
Copy Markdown
Contributor

aneeshkp commented Jul 12, 2022

/test e2e-aws

@aneeshkp
Copy link
Copy Markdown
Contributor

aneeshkp commented Jul 12, 2022

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 12, 2022
@aneeshkp
Copy link
Copy Markdown
Contributor

aneeshkp commented Jul 12, 2022

/retest

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jul 12, 2022

@edcdavid: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aneeshkp
Copy link
Copy Markdown
Contributor

aneeshkp commented Jul 13, 2022

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jul 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aneeshkp, edcdavid, josephdrichard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [aneeshkp,josephdrichard]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2022
@openshift-ci openshift-ci bot merged commit c042ef4 into openshift:master Jul 13, 2022
jzding pushed a commit to jzding/ptp-operator that referenced this pull request Mar 21, 2026
@openshift-merge-robot
Merge pull request openshift#197 from aneeshkp/change-gpsd-vendor
d23f6c4 
Add gpsd lib with changes merged by original author
jzding added a commit to jzding/ptp-operator that referenced this pull request Mar 26, 2026
@jzding
Merge pull request openshift#197 from aabughosh/addlocktest
7ae692d 
CNF-19617: Add test coverage for clockClass verification when locking PTP source
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pliurh pliurh Awaiting requested review from pliurh

@SchSeba SchSeba Awaiting requested review from SchSeba

2 more reviewers

@aneeshkp aneeshkp aneeshkp approved these changes

@josephdrichard josephdrichard josephdrichard approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@aneeshkp aneeshkp

@josephdrichard josephdrichard

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@edcdavid @josephdrichard @aneeshkp