[MTSRE-666] feat: add uninstall phase#15
[MTSRE-666] feat: add uninstall phase#15openshift-merge-robot merged 1 commit intoopenshift:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ajpantuso The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
Ajpantuso
force-pushed
the
apantuso/controller_refactor
branch
from
a671ade to
8cfd02d
Compare
Ajpantuso
changed the title
Ajpantuso
force-pushed
the
apantuso/controller_refactor
branch
7 times, most recently
from
6f4fe13 to
24b7a76
Compare
Ajpantuso
force-pushed
the
apantuso/controller_refactor
branch
from
24b7a76 to
3a2fb48
Compare
|
@Ajpantuso: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| return &ReferenceAddonReconciler{ | ||
| cfg: cfg, | ||
| phases: []phase.Phase{ | ||
| NewPhaseUninstall( |
There was a problem hiding this comment.
a comment mentioning that the order of phases matter (or is recommended) will be helpful for other developers. As the Uninstall phase is intented to remove resources and block (skip) further Reconcile phases.
| } | ||
|
|
||
| var finalErr error | ||
|
|
There was a problem hiding this comment.
does checking len(csvs) == 0 make sense here.
It could be interpretted as either:
- already uninstalled and uninstalltion is clean
- was expecting some but none found (error)
May be we can return finalErr nil only if len(csvs) == 0. When there are csvs to be deleted we can delete them and requeue the event to ensure that CSVs are gone in the next reconcile loop.
|
/lgtm |
3 participants
Summary
Overhauls reconciler and adds uninstall logic.