refactor: make importance of phase order obvious

[Ajpantuso]

No description provided.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ajpantuso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [Ajpantuso]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nikhil-thomas]

I like this patch. However, I think the exiting implementation has the right level of simplicity for a reference-addon.

Now, i wonder whether it is better to keep it as it is. 🧑‍💻🤔

[Ajpantuso]

I like this patch. However, I think the exiting implementation has the right level of simplicity for a reference-addon.

Now, i wonder whether it is better to keep it as it is. technologistthinking

@nikhil-thomas updated this to a var name change to make the importance of ordering more obvious. I think this is a simpler way to achieve the same clarity.

[openshift-ci]

@Ajpantuso: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[nikhil-thomas]

/lgtm
🧑‍💻👍