Skip to content

improve feature analysis loading#663

Merged
openshift-merge-bot[bot] merged 3 commits intoopenshift:mainfrom
hoxhaeris:improve_feature_analysis_loading
Feb 28, 2025
Merged

improve feature analysis loading#663
openshift-merge-bot[bot] merged 3 commits intoopenshift:mainfrom
hoxhaeris:improve_feature_analysis_loading

Conversation

@hoxhaeris
Copy link
Copy Markdown
Contributor

@hoxhaeris hoxhaeris commented Feb 28, 2025

If the feature analysis takes longer than 15 seconds to load, return a wait-and-come-back-later message.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2025
@hoxhaeris
Copy link
Copy Markdown
Contributor Author

hoxhaeris commented Feb 28, 2025

/hold
The PR is ready for review, but adding a hold because I want to follow-up the roll-up.

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 28, 2025
Copy link
Copy Markdown
Collaborator

@bradmwilliams bradmwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the page auto-refresh by itself?

@hoxhaeris
Copy link
Copy Markdown
Contributor Author

Will the page auto-refresh by itself?

No, currently it does not do that, but that's a good idea, I'll have a look.

@hoxhaeris
Copy link
Copy Markdown
Contributor Author

Will the page auto-refresh by itself?

After the timeout is reached (15 sec now), an HTML with a meta refresh is returned, so the page reloads automatically.

@hoxhaeris hoxhaeris force-pushed the improve_feature_analysis_loading branch from 67b7820 to 7d3dead Compare February 28, 2025 17:03
@hoxhaeris
Copy link
Copy Markdown
Contributor Author

hoxhaeris commented Feb 28, 2025

Will the page auto-refresh by itself?

After the timeout is reached (15 sec now), an HTML with a meta refresh is returned, so the page reloads automatically.

@bradmwilliams , do you think this is fine?
image

@bradmwilliams
Copy link
Copy Markdown
Collaborator

Yes, I think that's great

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2025
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2025
@hoxhaeris
Copy link
Copy Markdown
Contributor Author

/label tide/merge-method-squash

@openshift-ci openshift-ci Bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 28, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 28, 2025

@hoxhaeris: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/govulncheck b72a6f5 link false /test govulncheck
ci/prow/security b72a6f5 link false /test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradmwilliams, hoxhaeris

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [bradmwilliams,hoxhaeris]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hoxhaeris
Copy link
Copy Markdown
Contributor Author

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 28, 2025
@openshift-merge-bot openshift-merge-bot Bot merged commit 59fa358 into openshift:main Feb 28, 2025
@hoxhaeris hoxhaeris deleted the improve_feature_analysis_loading branch February 28, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants