release-payload-controller/*test.go: improve tests#667
release-payload-controller/*test.go: improve tests#667openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
Conversation
|
/hold |
openshift-ci
Bot
added
the
do-not-merge/hold
openshift-ci
Bot
added
the
approved
This PR updates all Release Payload Controller unit tests to use `New...Controller` functions instead of manually creating the structs. It also adds `t.Parallel` to all tests. This reduces test runtime for the `pkg/cmd/release-payload-controller` package from 7 seconds to 1.4 seconds on my system.
AlexNPavel
force-pushed
the
cleanup-payload-tests
branch
from
0ecd583 to
aace164
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlexNPavel, bradmwilliams The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@AlexNPavel: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@AlexNPavel Let's sit on this one until we're sure that all the other updates have successfully rolled out and things are operating as expected. |
|
@AlexNPavel I'd say we are good to go with this one. |
|
/hold cancel |
openshift-ci
Bot
removed
the
do-not-merge/hold
2 participants
This PR updates all Release Payload Controller unit tests to use
New...Controllerfunctions instead of manually creating the structs. It also addst.Parallelto all tests. This reduces test runtime for thepkg/cmd/release-payload-controllerpackage from 7 seconds to 1.4 seconds on my system.