Skip to content

Adding a nil check for AlternateImageRepository #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Apr 3, 2025
Merged

Adding a nil check for AlternateImageRepository #673

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cmd/release-controller/sync_release.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,6 +375,10 @@ func jobIsComplete(job *batchv1.Job) (succeeded bool, complete bool) {
// Command should be like:
// $ oc image mirror --keep-manifest-list=true registry.ci.openshift.org/ocp/release:4.17.0-0.ci-2024-08-30-110931 quay.io/openshift-release-dev/dev-release:4.17.0-0.ci-2024-08-30-110931
func (c *Controller) ensureReleaseMirrorJob(release *releasecontroller.Release, name string, mirror *imagev1.ImageStream) (*batchv1.Job, error) { //nolint:unused
if len(release.Config.AlternateImageRepository) == 0 {
klog.Warningf("Unable to create release mirror job for %s: no alternateImageRepository defined", name)
return nil, nil
}
return c.ensureJob(releaseMirrorJobName(name), nil, func() (*batchv1.Job, error) {
fromImage := fmt.Sprintf("%s:%s", release.Target.Status.PublicDockerImageRepository, name)
toImage := fmt.Sprintf("%s:%s", release.Config.AlternateImageRepository, name)
Expand Down