Skip to content

*: fix issues idenfied by golangci-lint 2.0#674

Merged
openshift-merge-bot[bot] merged 3 commits intoopenshift:mainfrom
AlexNPavel:new-linting
Apr 10, 2025
Merged

*: fix issues idenfied by golangci-lint 2.0#674
openshift-merge-bot[bot] merged 3 commits intoopenshift:mainfrom
AlexNPavel:new-linting

Conversation

@AlexNPavel
Copy link
Copy Markdown
Contributor

@AlexNPavel AlexNPavel commented Apr 10, 2025 •
edited
Loading

Fix all issues listed by golangci-lint's latest updates and run the gopls modernizer.
Also disable errcheck for certain functions via .golangci.yaml

@AlexNPavel
Copy link
Copy Markdown
Contributor Author

AlexNPavel commented Apr 10, 2025

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 10, 2025
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 10, 2025

@AlexNPavel: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/govulncheck 52b698f link false /test govulncheck
ci/prow/security 52b698f link false /test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hoxhaeris
Copy link
Copy Markdown
Contributor

hoxhaeris commented Apr 10, 2025

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2025
bradmwilliams
bradmwilliams approved these changes Apr 10, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@bradmwilliams bradmwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexNPavel, bradmwilliams, hoxhaeris

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [AlexNPavel,bradmwilliams,hoxhaeris]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@AlexNPavel
Copy link
Copy Markdown
Contributor Author

AlexNPavel commented Apr 10, 2025

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 10, 2025
@openshift-merge-bot openshift-merge-bot Bot merged commit 7872889 into openshift:main Apr 10, 2025
6 of 8 checks passed
@AlexNPavel AlexNPavel deleted the new-linting branch April 14, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bradmwilliams bradmwilliams bradmwilliams approved these changes

@hoxhaeris hoxhaeris Awaiting requested review from hoxhaeris

Assignees

@bradmwilliams bradmwilliams

@hoxhaeris hoxhaeris

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AlexNPavel @hoxhaeris @bradmwilliams