Skip to content

Bumping to the latest/greatest jira-lifecycle-plugin#742

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
bradmwilliams:jira-lifecycle-plugin-bump
Mar 16, 2026
Merged

Bumping to the latest/greatest jira-lifecycle-plugin#742
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
bradmwilliams:jira-lifecycle-plugin-bump

Conversation

@bradmwilliams
Copy link
Copy Markdown
Collaborator

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 16, 2026

Walkthrough

This pull request updates three key dependency versions in go.mod (jira-lifecycle-plugin, Kubernetes API libraries) and removes an unused transitive dependency. Additionally, test custom field IDs are replaced with new values across jira_test.go fixtures to align with updated field mappings.

Changes

Cohort / File(s) Summary
Dependency Updates
go.mod
Bumps jira-lifecycle-plugin to v0.0.0-20260316124234-fc8cf3e48910, updates k8s.io/api and k8s.io/apimachinery from v0.34.1 to v0.34.2, and removes golang.org/x/tools/go/expect indirect dependency.
Test Fixture Updates
pkg/jira/jira_test.go
Replaces Jira custom field IDs (customfield_12315948 → customfield_10470, customfield_12319940 → customfield_10855) across test fixtures and expected structures without altering test logic.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from AlexNPavel and hoxhaeris March 16, 2026 13:49
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 16, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradmwilliams, hoxhaeris

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [bradmwilliams,hoxhaeris]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
go.mod (1)

48-50: Align k8s.io package versions for consistency.

The following k8s.io packages have inconsistent versions: k8s.io/api and k8s.io/apimachinery are at v0.34.2, while k8s.io/client-go, k8s.io/code-generator, k8s.io/component-base, and k8s.io/apiserver remain at v0.34.1. Since these packages are typically released together, aligning them prevents potential subtle incompatibilities and improves maintainability.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@go.mod` around lines 48 - 50, Update the k8s.io module versions so they are
consistent: change k8s.io/client-go, k8s.io/code-generator,
k8s.io/component-base, and k8s.io/apiserver to match k8s.io/api and
k8s.io/apimachinery (e.g., v0.34.2) in go.mod; run `go mod tidy` (or the
equivalent dependency update) afterwards to ensure the module graph is resolved
and go.sum updated.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@go.mod`:
- Around line 48-50: Update the k8s.io module versions so they are consistent:
change k8s.io/client-go, k8s.io/code-generator, k8s.io/component-base, and
k8s.io/apiserver to match k8s.io/api and k8s.io/apimachinery (e.g., v0.34.2) in
go.mod; run `go mod tidy` (or the equivalent dependency update) afterwards to
ensure the module graph is resolved and go.sum updated.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 709bbd78-62ab-49e2-9dd3-97b30bd5b490

📥 Commits

Reviewing files that changed from the base of the PR and between 7282818 and 1ad1bc1.

⛔ Files ignored due to path filters (3)
  • go.sum is excluded by !**/*.sum
  • vendor/github.com/openshift-eng/jira-lifecycle-plugin/pkg/helpers/helpers.go is excluded by !vendor/**, !**/vendor/**
  • vendor/modules.txt is excluded by !vendor/**, !**/vendor/**
📒 Files selected for processing (2)
  • go.mod
  • pkg/jira/jira_test.go

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 16, 2026

@bradmwilliams: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 8cec51f into openshift:main Mar 16, 2026
9 checks passed
@bradmwilliams bradmwilliams deleted the jira-lifecycle-plugin-bump branch March 16, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants