Skip to content

Add: set default sc ref #37108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 13, 2023
Merged

Add: set default sc ref #37108

merged 2 commits into from
Mar 13, 2023

Conversation

Phaow
Copy link
Contributor

@Phaow Phaow commented Mar 9, 2023

Add set default sc ref to extend qe test CI test coverage.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 9, 2023
@openshift-ci-robot
Copy link
Contributor

@Phaow: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-aws-ipi-network-mtu-localzone-p3-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-4.13-upgrade-from-ec-4.13-aws-ipi-network-mtu-localzone-p2-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-stable-aws-ipi-network-mtu-localzone-p2-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-aws-ipi-network-mtu-localzone-p3-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-stable-aws-ipi-network-mtu-localzone-p3-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-aws-ipi-network-mtu-localzone-p2-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-aws-ipi-network-mtu-localzone-p2-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-4.12-upgrade-from-stable-4.12-aws-ipi-network-mtu-localzone-p2-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-aws-ipi-network-mtu-localzone-p2-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-4.12-upgrade-from-stable-4.12-aws-ipi-network-mtu-localzone-p2-pewang-debug N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-aws-ipi-network-mtu-localzone-p3-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-master-installer-rehearse-4.12-installer-rehearse-aws-1 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-4.13-upgrade-from-stable-4.12-aws-ipi-network-mtu-localzone-p2-f14 N/A periodic Registry content changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@Phaow
Copy link
Contributor Author

Phaow commented Mar 9, 2023

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-4.12-upgrade-from-stable-4.12-aws-ipi-network-mtu-localzone-p2-pewang-debug

@openshift-ci openshift-ci bot requested review from gnufied and gpei March 9, 2023 11:00
@openshift-ci-robot
Copy link
Contributor

@Phaow: job(s): periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-4.12-upgrade-from-stable-4.12-aws-ipi-network-mtu-localzone-p2-pewang-debu either don't exist or were not found to be affected, and cannot be rehearsed

@Phaow Phaow force-pushed the add-set-sc-ref branch 3 times, most recently from af02afe to 8c57d36 Compare March 10, 2023 08:17
@Phaow Phaow changed the title [WIP]Add: set default sc ref Add: set default sc ref Mar 10, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 10, 2023
@Phaow
Copy link
Contributor Author

Phaow commented Mar 10, 2023

/uncc @gpei

@openshift-ci openshift-ci bot removed the request for review from gpei March 10, 2023 08:28
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 10, 2023

@Phaow: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-4.12-upgrade-from-stable-4.12-aws-ipi-network-mtu-localzone-p2-pewang-debug cb12a9174833fa6461bd77684dce6cdc184e5324 link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-4.12-upgrade-from-stable-4.12-aws-ipi-network-mtu-localzone-p2-pewang-debug

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Phaow Phaow requested review from jsafrane and removed request for gnufied March 12, 2023 08:45
@Phaow
Copy link
Contributor Author

Phaow commented Mar 13, 2023

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Mar 13, 2023
@jsafrane
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, Phaow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2023
@jsafrane
Copy link
Contributor

/pj-rehearse refresh

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 13, 2023
@openshift-ci-robot
Copy link
Contributor

@jsafrane: no rehearsable tests are affected by this change

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jsafrane
Copy link
Contributor

/pj-rehearse ack

@openshift-merge-robot openshift-merge-robot merged commit 1bd9743 into openshift:master Mar 13, 2023
bmanzari pushed a commit to bmanzari/release that referenced this pull request Mar 30, 2023
@Phaow @bmanzari
Add: set default sc ref (openshift#37108)
7ed7b98 
* Add: set default sc ref

* Fix: separate refs
@Phaow Phaow mentioned this pull request Apr 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@jsafrane jsafrane

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Phaow @openshift-ci-robot @jsafrane @openshift-merge-robot