Fix HUB and PR_NUMBER environment variable propagation in E2E tests #74603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Feb 9, 2026

-Original file line number
+Diff line change
@@ Expand Up / @@ -76,6 +76,7 @@ tests: @@
         cluster_profile: ossm-aws
         env:
           BASE_DOMAIN: servicemesh.devcluster.openshift.com
+          HUB: quay.io/sail-dev
           INSTALLATION_METHOD: helm
           MAISTRA_BUILDER_IMAGE: quay-proxy.ci.openshift.org/openshift/ci:ci_maistra-builder_upstream-master
           MAISTRA_NAMESPACE: maistra-e2e-test
@@ Expand All / @@ -95,6 +96,7 @@ tests: @@
         env:
           COMPUTE_NODE_TYPE: m6g.xlarge
           CONTROL_PLANE_INSTANCE_TYPE: m6g.xlarge
+          HUB: quay.io/sail-dev
           INSTALLATION_METHOD: helm
           MAISTRA_BUILDER_IMAGE: gcr.io/istio-testing/build-tools:master-eebcdda8856e2d4f528991d27d4808880cce4c52
           MAISTRA_NAMESPACE: maistra-e2e-test
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -29,6 +29,7 @@ tests: @@
       steps:
         cluster_profile: ossm-aws
         env:
+          HUB: quay.io/sail-dev
           INSTALLATION_METHOD: helm
           MAISTRA_BUILDER_IMAGE: gcr.io/istio-testing/build-tools:master-eebcdda8856e2d4f528991d27d4808880cce4c52
           MAISTRA_NAMESPACE: maistra-e2e-test
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -98,6 +98,7 @@ tests: @@
         cluster_profile: ossm-aws
         env:
           BASE_DOMAIN: servicemesh.devcluster.openshift.com
+          HUB: quay.io/sail-dev
           INSTALLATION_METHOD: helm
           MAISTRA_BUILDER_IMAGE: quay-proxy.ci.openshift.org/openshift/ci:ci_maistra-builder_upstream-1.24
           MAISTRA_NAMESPACE: maistra-e2e-test
@@ Expand All / @@ -117,6 +118,7 @@ tests: @@
         env:
           COMPUTE_NODE_TYPE: m6g.xlarge
           CONTROL_PLANE_INSTANCE_TYPE: m6g.xlarge
+          HUB: quay.io/sail-dev
           INSTALLATION_METHOD: helm
           MAISTRA_BUILDER_IMAGE: gcr.io/istio-testing/build-tools:release-1.24-f9fb31e097a085fca3995f19f051cb8f8a396837
           MAISTRA_NAMESPACE: maistra-e2e-test
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -30,6 +30,7 @@ tests: @@
         cluster_profile: ossm-aws
         env:
           BASE_DOMAIN: servicemesh.devcluster.openshift.com
+          HUB: quay.io/sail-dev
           INSTALLATION_METHOD: helm
           MAISTRA_BUILDER_IMAGE: gcr.io/istio-testing/build-tools:release-1.24-f9fb31e097a085fca3995f19f051cb8f8a396837
           MAISTRA_NAMESPACE: maistra-e2e-test
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -96,6 +96,7 @@ tests: @@
         cluster_profile: ossm-aws
         env:
           BASE_DOMAIN: servicemesh.devcluster.openshift.com
+          HUB: quay.io/sail-dev
           INSTALLATION_METHOD: helm
           MAISTRA_BUILDER_IMAGE: quay-proxy.ci.openshift.org/openshift/ci:ci_maistra-builder_upstream-1.26
           MAISTRA_NAMESPACE: maistra-e2e-test
@@ Expand All / @@ -115,6 +116,7 @@ tests: @@
         env:
           COMPUTE_NODE_TYPE: m6g.xlarge
           CONTROL_PLANE_INSTANCE_TYPE: m6g.xlarge
+          HUB: quay.io/sail-dev
           INSTALLATION_METHOD: helm
           MAISTRA_BUILDER_IMAGE: gcr.io/istio-testing/build-tools:release-1.26-512a1e34a2bc63dd3c54ddcba27df1bcf95e7360
           MAISTRA_NAMESPACE: maistra-e2e-test
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -29,6 +29,7 @@ tests: @@
       steps:
         cluster_profile: ossm-aws
         env:
+          HUB: quay.io/sail-dev
           INSTALLATION_METHOD: helm
           MAISTRA_BUILDER_IMAGE: gcr.io/istio-testing/build-tools:release-1.26-512a1e34a2bc63dd3c54ddcba27df1bcf95e7360
           MAISTRA_NAMESPACE: maistra-e2e-test
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -96,6 +96,7 @@ tests: @@
         cluster_profile: ossm-aws
         env:
           BASE_DOMAIN: servicemesh.devcluster.openshift.com
+          HUB: quay.io/sail-dev
           INSTALLATION_METHOD: helm
           MAISTRA_BUILDER_IMAGE: quay-proxy.ci.openshift.org/openshift/ci:ci_maistra-builder_upstream-1.27
           MAISTRA_NAMESPACE: maistra-e2e-test
@@ Expand All / @@ -115,6 +116,7 @@ tests: @@
         env:
           COMPUTE_NODE_TYPE: m6g.xlarge
           CONTROL_PLANE_INSTANCE_TYPE: m6g.xlarge
+          HUB: quay.io/sail-dev
           INSTALLATION_METHOD: helm
           MAISTRA_BUILDER_IMAGE: gcr.io/istio-testing/build-tools:release-1.27-7464103ed8bdbef724dc2527199ede06ec3820a5
           MAISTRA_NAMESPACE: maistra-e2e-test
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -29,6 +29,7 @@ tests: @@
       steps:
         cluster_profile: ossm-aws
         env:
+          HUB: quay.io/sail-dev
           INSTALLATION_METHOD: helm
           MAISTRA_BUILDER_IMAGE: gcr.io/istio-testing/build-tools:release-1.27-7464103ed8bdbef724dc2527199ede06ec3820a5
           MAISTRA_NAMESPACE: maistra-e2e-test
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -110,6 +110,8 @@ spec: @@
           value: "${PULL_PULL_SHA:-}"
         - name: PULL_HEAD_REF
           value: "${PULL_HEAD_REF:-}"
+        - name: HUB
+          value: "${HUB:-}"
         volumeMounts:
         - mountPath: /lib/modules
           name: modules
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -98,7 +98,7 @@ run_tests() { @@
         export CI=\"${CI:-true}\"
         export HUB=\"${HUB:-quay.io/sail-dev}\"
         export USE_INTERNAL_REGISTRY=\"false\"
-        export PR_NUMBER=\"${PR_NUMBER:-}\"
+        export PR_NUMBER=\"${PULL_NUMBER:-}\"
         ${VERSIONS_YAML_CONFIG:-}
         oc version
         cd /work
@@ Expand Down @@

Provide feedback