Skip to content

OCM-12285 | feat: Update cluster autoscaler max value (180->249)#2591

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
hunterkepley:ocm-12285
Nov 4, 2024
Merged

OCM-12285 | feat: Update cluster autoscaler max value (180->249)#2591
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
hunterkepley:ocm-12285

Conversation

@hunterkepley

Copy link
Copy Markdown
Contributor

No description provided.

@openshift-ci openshift-ci Bot requested review from den-rgb and robpblake November 4, 2024 15:54
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2024
@den-rgb

den-rgb commented Nov 4, 2024

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2024
@davidleerh

Copy link
Copy Markdown
Contributor

/test coverage

@davidleerh

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci

openshift-ci Bot commented Nov 4, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidleerh, den-rgb, hunterkepley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [davidleerh,den-rgb,hunterkepley]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Nov 4, 2024

Copy link
Copy Markdown
Contributor

@hunterkepley: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov

codecov Bot commented Nov 4, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 30.09%. Comparing base (70c779d) to head (1b9cbf1).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/clusterautoscaler/flags.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2591   +/-   ##
=======================================
  Coverage   30.09%   30.09%           
=======================================
  Files         174      174           
  Lines       24010    24010           
=======================================
  Hits         7226     7226           
  Misses      16199    16199           
  Partials      585      585           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 814dd48 into openshift:master Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants