OCM-21381 | fix: Change regex to support new ID convention#3142
Merged
hunterkepley merged 1 commit intoopenshift:masterfrom Dec 13, 2025
Merged
OCM-21381 | fix: Change regex to support new ID convention#3142hunterkepley merged 1 commit intoopenshift:masterfrom
hunterkepley merged 1 commit intoopenshift:masterfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hunterkepley The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Contributor
|
The new regex looks good, and should match the entire string of a lower case internal or external cluster id. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some reason the IDs were changed in the API today from
normal cluster-styleIDs toExternal IDstyle IDsIE it went from
2n4b8f8ai80cs6kmjmdgqlqplh73r411to8ea363cb-85b7-44ee-a834-ade89d9adbd2This MR adds new regex to satisfy this unexpected change
the new regex is backwards compatible with the old ID convention, so there's no risk with this change if it is deemed a bug in the API and changed back