ROSAENG-59446 | test: Fixing id:38783,id:44776,id:84761,id:38770,id:38857,id:74433,id:43067

[jerichokeyne]

PR Summary

Fixes a few test failures that occurred during 1.2.64 regression testing

Detailed Description of the Issue

Related Issues and PRs

• Jira: https://redhat.atlassian.net/browse/ROSAENG-59446
• Fixes: #
• Related PR(s):
• Related design/docs:

Type of Change

• feat - adds a new user-facing capability.
• fix - resolves an incorrect behavior or bug.
• docs - updates documentation only.
• style - formatting or naming changes with no logic impact.
• refactor - code restructuring with no behavior change.
• test - adds or updates tests only.
• chore - maintenance work (tooling, housekeeping, non-product code).
• build - changes build system, packaging, or dependencies for build output.
• ci - changes CI pipelines, jobs, or automation workflows.
• perf - improves performance without changing intended behavior.

Previous Behavior

Behavior After This Change

How to Test (Step-by-Step)

Preconditions

Test Steps

Expected Results

Proof of the Fix

• Screenshots:
• Videos:
• Logs/CLI output:
• Other artifacts:

Breaking Changes

• No breaking changes
• Yes, this PR introduces a breaking change (describe impact and migration plan below)

Breaking Change Details / Migration Plan

Developer Verification Checklist

• Commit subject/title follows [JIRA-TICKET] | [TYPE]: <MESSAGE>.
• PR description clearly explains both what changed and why.
• Relevant Jira/GitHub issues and related PRs are linked.
• make install-hooks has been run in this clone.
• Tests were added/updated where appropriate.
• I manually tested the change.
• make test passes.
• make lint passes.
• make rosa passes.
• Documentation or repo-local agent guidance was added/updated where appropriate.
• Any risk, limitation, or follow-up work is documented.

Summary by CodeRabbit

Release Notes

• Tests
  • Strengthened validation test assertions across account-role creation, cluster creation/editing, and machine pool operations.
  • Enhanced error validation consistency using improved assertion methods.
  • Implemented eventual consistency handling for image mirror creation and deletion to improve test reliability.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: eedd22f7-8a50-4889-a1c0-3e7592dad8e6

📥 Commits

Reviewing files that changed from the base of the PR and between 920b78d and 4d09908.

📒 Files selected for processing (4)

• tests/e2e/test_rosacli_account_roles.go
• tests/e2e/test_rosacli_cluster.go
• tests/e2e/test_rosacli_image_mirror.go
• tests/e2e/test_rosacli_machine_pool.go

---

📝 Walkthrough

Walkthrough

Four e2e test files are updated. In test_rosacli_account_roles.go, test_rosacli_cluster.go, and test_rosacli_machine_pool.go, negative-validation test cases are refactored to call helper.ExpectErrorWithMessage(err, <substring>) instead of inspecting CLI stdout text or using HaveOccurred() with manual substring assertions. Several expected error message strings are also updated to match current CLI output (e.g., billing-account format, multi-AZ replica wording). In test_rosacli_image_mirror.go, the second image-mirror creation and both image-mirror deletions are wrapped in Gomega Eventually(...).WithTimeout(time.Minute * 1).Should(Succeed()) retry loops to accommodate eventual consistency.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the Jira ticket and indicates test fixes with specific test IDs, directly corresponding to the actual changes in the PR.
Description check	✅ Passed	The description covers the main issue (test failures in 1.2.64 regression testing), links to the Jira ticket, confirms test-only changes, and verifies all required checks pass.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	All test titles in modified files use static, descriptive strings with no dynamic content (timestamps, UUIDs, variables, pod names). All Ginkgo test names are stable and deterministic.
Test Structure And Quality	✅ Passed	Tests meet quality requirements: (1) Proper setup/cleanup via BeforeEach/AfterEach, (2) Image mirror test includes appropriate 1-minute timeouts on Eventually blocks for eventual consistency, (3) A...
Microshift Test Compatibility	✅ Passed	This PR modifies existing Ginkgo test blocks (fixing test IDs 38783, 44776, 84761, 38770, 38857, 74433, 43067), not adding new ones. The custom check applies only to newly added tests, making it no...
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR does not add new Ginkgo e2e tests; it only modifies existing tests to fix failures. The check is not applicable when no new test blocks are introduced.
Topology-Aware Scheduling Compatibility	✅ Passed	This PR contains only test-only changes (4 e2e test files) and configuration files. No deployment manifests, operator code, controllers, or scheduling constraints are introduced or modified.
Ote Binary Stdout Contract	✅ Passed	All modified test files contain only test-level stdout writes (inside It/BeforeEach blocks) which are intercepted by Ginkgo framework; no process-level writes to stdout detected in main, init, Befo...
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new Ginkgo e2e tests are added; this PR only modifies existing tests by refactoring assertions and error handling. The custom check applies only to newly added tests, making it not applicable here.
No-Weak-Crypto	✅ Passed	PR contains no weak crypto algorithms, custom crypto implementations, or non-constant-time secret comparisons. Changes are test-only with no cryptographic operations.
Container-Privileges	✅ Passed	PR contains only test file modifications (4 Go test files) with no container/Kubernetes manifest changes. No privileged container configurations were introduced.
No-Sensitive-Data-In-Logs	✅ Passed	PR contains only test refactoring changes. No new logging of sensitive data detected: fmt.Println logs test metadata (account roles, proxy config), log.Logger calls at DEBUG/INFO level log test con...

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[amandahla]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amandahla, jerichokeyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• tests/OWNERS [amandahla,jerichokeyne]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment