Skip to content

OCPBUGS-86184: OCPBUGS-83892: Update grpc-go and x/net#90

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:release-4.22from
rikatz:bump-gogrpc-xnet-4-22
May 19, 2026
Merged

OCPBUGS-86184: OCPBUGS-83892: Update grpc-go and x/net#90
openshift-merge-bot[bot] merged 2 commits into
openshift:release-4.22from
rikatz:bump-gogrpc-xnet-4-22

Conversation

@rikatz
Copy link
Copy Markdown
Member

@rikatz rikatz commented May 19, 2026

This PR updates grpc and x/net due to existent CVEs on these libraries

Commands used to update:

go get google.golang.org/grpc
go get golang.org/x/net
go mod tidy
go mod vendor

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 19, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@rikatz: This pull request references Jira Issue OCPBUGS-83892, which is invalid:

  • expected the bug to be open, but it isn't
  • expected the vulnerability to target either version "4.22." or "openshift-4.22.", but it targets "5.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Done) instead
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-83892 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 19, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 869f23de-1c62-4f7c-9fe3-8ef14af2234f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from alebedev87 and miheer May 19, 2026 14:47
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2026
@rikatz
Copy link
Copy Markdown
Member Author

rikatz commented May 19, 2026

/jira cherrypick OCPBUGS-83892

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@rikatz: Jira Issue OCPBUGS-83892 has been cloned as Jira Issue OCPBUGS-86184. Will retitle bug to link to clone.
/retitle OCPBUGS-86184: OCPBUGS-83892: Update grpc-go and x/net

Details

In response to this:

/jira cherrypick OCPBUGS-83892

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot changed the title OCPBUGS-83892: Update grpc-go and x/net OCPBUGS-86184: OCPBUGS-83892: Update grpc-go and x/net May 19, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@rikatz: This pull request references Jira Issue OCPBUGS-86184, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-83892 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is Closed (Done) instead
  • expected dependent Jira Issue OCPBUGS-83892 to target a version in 5.0.0, but it targets "5.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rikatz
Copy link
Copy Markdown
Member Author

rikatz commented May 19, 2026

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 19, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@rikatz: This pull request references Jira Issue OCPBUGS-86184, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-83892 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-83892 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
  • bug has dependents
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rikatz
Copy link
Copy Markdown
Member Author

rikatz commented May 19, 2026

/cc @gcs278 @Miciah @candita
for review, lgtm, approval, label for backport risk assessed
/cc @melvinjoseph86 @rhamini3
for QE verification

thanks

@rikatz
Copy link
Copy Markdown
Member Author

rikatz commented May 19, 2026

/retest-required

@rhamini3
Copy link
Copy Markdown

tested on clusterbot

oc rsync -n openshift-route-controller-manager route-controller-manager-5559d9d57-6wln2:/usr/bin/route-controller-manager .
Transfer starting: 1 files
route-controller-manager

sent 38 bytes  received 108255697 bytes  1082557350000 bytes/sec
total size is 108229168  speedup is 1.00
iamin@iamin-mac openshift-tests-private % oc -n openshift-route-controller-manager get pods                                                                        
NAME                                       READY   STATUS    RESTARTS   AGE
route-controller-manager-5559d9d57-6wln2   1/1     Running   0          79m
route-controller-manager-5559d9d57-gh49m   1/1     Running   0          79m
route-controller-manager-5559d9d57-trkn7   1/1     Running   0          79m
iamin@iamin-mac openshift-tests-private % oc rsync -n openshift-route-controller-manager route-controller-manager-5559d9d57-gh49m:/usr/bin/route-controller-manager .
Transfer starting: 1 files

sent 16 bytes  received 71 bytes  870000 bytes/sec
total size is 108229168  speedup is 1243999.13

marking bug as verified
/verified by @rhamini3

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label May 19, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@rhamini3: This PR has been marked as verified by @rhamini3.

Details

In response to this:

tested on clusterbot

oc rsync -n openshift-route-controller-manager route-controller-manager-5559d9d57-6wln2:/usr/bin/route-controller-manager .
Transfer starting: 1 files
route-controller-manager

sent 38 bytes  received 108255697 bytes  1082557350000 bytes/sec
total size is 108229168  speedup is 1.00
iamin@iamin-mac openshift-tests-private % oc -n openshift-route-controller-manager get pods                                                                        
NAME                                       READY   STATUS    RESTARTS   AGE
route-controller-manager-5559d9d57-6wln2   1/1     Running   0          79m
route-controller-manager-5559d9d57-gh49m   1/1     Running   0          79m
route-controller-manager-5559d9d57-trkn7   1/1     Running   0          79m
iamin@iamin-mac openshift-tests-private % oc rsync -n openshift-route-controller-manager route-controller-manager-5559d9d57-gh49m:/usr/bin/route-controller-manager .
Transfer starting: 1 files

sent 16 bytes  received 71 bytes  870000 bytes/sec
total size is 108229168  speedup is 1243999.13

marking bug as verified
/verified by @rhamini3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 19, 2026

@rikatz: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@candita
Copy link
Copy Markdown
Contributor

candita commented May 19, 2026

This is a CVE backport required in 4.22.
/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 19, 2026
@candita
Copy link
Copy Markdown
Contributor

candita commented May 19, 2026

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 19, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: candita, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 55f77ca into openshift:release-4.22 May 19, 2026
11 checks passed
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@rikatz: Jira Issue Verification Checks: Jira Issue OCPBUGS-86184
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-86184 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

This PR updates grpc and x/net due to existent CVEs on these libraries

Commands used to update:

go get google.golang.org/grpc
go get golang.org/x/net
go mod tidy
go mod vendor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants