Skip to content

Conversation

@xiaojiey
Copy link

@xiaojiey xiaojiey commented Jan 8, 2026

What type of PR is this?

/kind bug

What this PR does / why we need it:

Reload the SELinux policy is needed, otherwise you will still get the keycreate error.
This PR a test PR. It is based on #123.

Which issue(s) this PR fixes:

Does this PR have test?

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Vincent056 and others added 2 commits January 7, 2026 05:10
Add selinuxrecording.process to file_type attribute to fix container
creation failure with "write to /proc/self/attr/keycreate: Invalid
argument" on OpenShift 4.20 where CRI-O/crun 1.23+ strictly validates
keycreate contexts.

Signed-off-by: Vincent Shen <wenshen@redhat.com>
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2026
@Vincent056 Vincent056 changed the title Fix profile recording CMP-3537: Fix profile recording Jan 9, 2026
@Vincent056
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 9, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 9, 2026

@xiaojiey: This pull request references CMP-3537 which is a valid jira issue.

Details

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

Reload the SELinux policy is needed, otherwise you will still get the keycreate error.
This PR a test PR. It is based on #123.

Which issue(s) this PR fixes:

Does this PR have test?

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2026
@Vincent056
Copy link

Vincent056 commented Jan 9, 2026

I did that during the test but did not add to the code, but this looks good in the code.

Copy link

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jan 20, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaojiey, yuumasato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuumasato yuumasato merged commit 1e5cfb7 into openshift:release-0.10 Jan 20, 2026
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants