-
Notifications
You must be signed in to change notification settings - Fork 3
CMP-3537: Fix profile recording #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMP-3537: Fix profile recording #125
Conversation
Add selinuxrecording.process to file_type attribute to fix container creation failure with "write to /proc/self/attr/keycreate: Invalid argument" on OpenShift 4.20 where CRI-O/crun 1.23+ strictly validates keycreate contexts. Signed-off-by: Vincent Shen <wenshen@redhat.com>
|
/lgtm |
|
@xiaojiey: This pull request references CMP-3537 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
I did that during the test but did not add to the code, but this looks good in the code. |
yuumasato
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xiaojiey, yuumasato The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Reload the SELinux policy is needed, otherwise you will still get the keycreate error.
This PR a test PR. It is based on #123.
Which issue(s) this PR fixes:
Does this PR have test?
Special notes for your reviewer:
Does this PR introduce a user-facing change?