Skip to content

Conversation

@Vincent056
Copy link

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Reverts:

  • a0a23f0 selinux: fix keycreate error for recording on OpenShift 4.20+
  • 3c39cf3 Reload the SELinux policy

The original fix was not needed, as manually do semodule -R using oc debug node command will fix the issue.

Which issue(s) this PR fixes:

None

Does this PR have test?

N/A

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Reverts:
- a0a23f0 selinux: fix keycreate error for recording on OpenShift 4.20+
- 3c39cf3 Reload the SELinux policy
@openshift-ci openshift-ci bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 29, 2026
@openshift-ci
Copy link

openshift-ci bot commented Jan 29, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Vincent056

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2026
@Vincent056 Vincent056 changed the title Revert selinux keycreate fix and policy reload CMP-3537: Revert selinux keycreate fix and policy reload Jan 29, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 29, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 29, 2026

@Vincent056: This pull request references CMP-3537 which is a valid jira issue.

Details

In response to this:

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Reverts:

  • a0a23f0 selinux: fix keycreate error for recording on OpenShift 4.20+
  • 3c39cf3 Reload the SELinux policy

The original fix was not needed, as manually do semodule -R using oc debug node command will fix the issue.

Which issue(s) this PR fixes:

None

Does this PR have test?

N/A

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Vincent056 Vincent056 force-pushed the test-keycreate-fix-removal branch from 9c6f479 to 412d235 Compare January 29, 2026 16:18
@yuumasato
Copy link

@Vincent056 But didn't the fix handle at least some of the OCP versions? Wasn't that a partial fix?

@xiaojiey
Copy link

xiaojiey commented Feb 4, 2026

@Vincent056 But didn't the fix handle at least some of the OCP versions? Wasn't that a partial fix?

No, the issue is the auto reload of semodules doesn't work. It doesn't make any difference with/without the fix.

@Vincent056 Vincent056 merged commit 412d235 into openshift:release-0.10 Feb 4, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants